[
https://issues.apache.org/jira/browse/HBASE-13473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14497598#comment-14497598
]
jeongmin kim commented on HBASE-13473:
--------------------------------------
[~tedyu]
Yes, as you confirmed, includeL0==true is confirmed.
But dropping deletes happens not only 'includeL0==true', but also
'canDropDeletesWithoutL0==true' which is not asserted.
so, we have to assert canDropDeletesWithoutL0 too.
it seems that L0 can be set to off by config and if it is,
canDropDeletesWithoutL0 can be always true. (i'm not 100% sure if it works that
way yet. but there is configuration to do it.)
And, if we use assert macro, it means
"if it's not qualified, the compaction is not going to be executed."
IMHO Base premise of dropping deletes while compaction is that all files have
to be selected.
Even though it is not, minor compaction still can be operated. I think we don't
have to cancel all the compaction job.
> deleted cells come back alive after the stripe compaction
> ---------------------------------------------------------
>
> Key: HBASE-13473
> URL: https://issues.apache.org/jira/browse/HBASE-13473
> Project: HBase
> Issue Type: Bug
> Components: Compaction
> Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12
> Reporter: jeongmin kim
> Assignee: jeongmin kim
> Priority: Blocker
> Labels: patch
> Attachments: HBASE-13473.patch
>
>
> during the STRIPE compaction,
> deletes(tombstones) are being dropped in 2 cases.
> 1. Compaction including L0 (includeL0 == true)
> 2. L0 has no files (canDropDeletesWithoutL0 == true)
> To drop delete marker and keep the consistency during compaction,
> All of HFiles in the stripe has to be selected, just like major compaction.
> otherwise, after the compaction only delete markers would be gone,
> and deleted cells (which is in the not-selected HFiles) are going to be alive
> again.
> In my cluster, there was no file on L0(canDropDeletesWithoutL0==true) and not
> all files are selected for compaction, so some of deleted rows have come back
> alive and appears when i get or scan after compactions.
> I made a patch about it.
> it checks if all files are selected before we set the majorRange of
> compaction request .
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
