[
https://issues.apache.org/jira/browse/HBASE-13473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498509#comment-14498509
]
Hadoop QA commented on HBASE-13473:
-----------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12725903/HBASE_13473-v2.patch
against master branch at commit ddab4726f6675943fc31b697a3d974bab74cd9ec.
ATTACHMENT ID: 12725903
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13722//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13722//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13722//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13722//console
This message is automatically generated.
> deleted cells come back alive after the stripe compaction
> ---------------------------------------------------------
>
> Key: HBASE-13473
> URL: https://issues.apache.org/jira/browse/HBASE-13473
> Project: HBase
> Issue Type: Bug
> Components: Compaction
> Affects Versions: 2.0.0, 1.0.1, 1.1.0, 0.98.12
> Reporter: jeongmin kim
> Assignee: jeongmin kim
> Priority: Blocker
> Labels: patch
> Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13
>
> Attachments: HBASE-13473.patch, HBASE_13473-v2.patch
>
>
> during the STRIPE compaction,
> deletes(tombstones) are being dropped in 2 cases.
> 1. Compaction including L0 (includeL0 == true)
> 2. L0 has no files (canDropDeletesWithoutL0 == true)
> To drop delete marker and keep the consistency during compaction,
> All of HFiles in the stripe has to be selected, just like major compaction.
> otherwise, after the compaction only delete markers would be gone,
> and deleted cells (which is in the not-selected HFiles) are going to be alive
> again.
> In my cluster, there was no file on L0(canDropDeletesWithoutL0==true) and not
> all files are selected for compaction, so some of deleted rows have come back
> alive and appears when i get or scan after compactions.
> I made a patch about it.
> it checks if all files are selected before we set the majorRange of
> compaction request .
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
