[
https://issues.apache.org/jira/browse/HBASE-13307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14499081#comment-14499081
]
Hadoop QA commented on HBASE-13307:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12725998/13307v6.txt
against master branch at commit e08ef99e3042767eaf2d11adae783674acfdddeb.
ATTACHMENT ID: 12725998
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
1911 checkstyle errors (more than the master's current 1910 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.sqoop.test.hive.InternalMetastoreServerRunner$1.call(InternalMetastoreServerRunner.java:53)
at
org.apache.sqoop.test.hive.InternalMetastoreServerRunner$1.call(InternalMetastoreServerRunner.java:50)
at
org.apache.sqoop.test.hive.InternalMetastoreServerRunner$1.call(InternalMetastoreServerRunner.java:53)
at
org.apache.sqoop.test.hive.InternalMetastoreServerRunner$1.call(InternalMetastoreServerRunner.java:50)
at
org.apache.sqoop.test.testcases.ConnectorTestCase.executeJob(ConnectorTestCase.java:298)
at
org.apache.sqoop.test.testcases.ConnectorTestCase.executeJob(ConnectorTestCase.java:314)
at
org.apache.sqoop.integration.connector.hive.FromRDBMSToKiteHiveTest.testCities(FromRDBMSToKiteHiveTest.java:124)
at
org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:84)
at org.testng.internal.Invoker.invokeMethod(Invoker.java:714)
at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:901)
at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1231)
at
org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127)
at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111)
at org.testng.TestRunner.privateRun(TestRunner.java:767)
at org.testng.TestRunner.run(TestRunner.java:617)
at org.testng.SuiteRunner.runTest(SuiteRunner.java:348)
at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:343)
at org.testng.SuiteRunner.privateRun(SuiteRunner.java:305)
at org.testng.SuiteRunner.run(SuiteRunner.java:254)
at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
at org.testng.TestNG.runSuitesSequentially(TestNG.java:1224)
at org.testng.TestNG.runSuitesLocally(TestNG.java:1149)
at org.testng.TestNG.run(TestNG.java:1057)
at
org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:77)
at
org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.executeSingleClass(TestNGDirectoryTestSuite.java:126)
at
org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.execute(TestNGDirectoryTestSuite.java:110)
at
org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:117)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13728//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13728//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13728//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13728//console
This message is automatically generated.
> Making methods under ScannerV2#next inlineable, faster
> ------------------------------------------------------
>
> Key: HBASE-13307
> URL: https://issues.apache.org/jira/browse/HBASE-13307
> Project: HBase
> Issue Type: Sub-task
> Components: Scanners
> Reporter: stack
> Assignee: stack
> Fix For: 2.0.0, 1.1.0
>
> Attachments: 13307.txt, 13307v2.branch-1.txt, 13307v3.branch-1.txt,
> 13307v4.branch-1.txt, 13307v5.branch-1.txt, 13307v6.branch-1.txt,
> 13307v6.txt, cpu.png, gc.png, next.png, traces.8.svg, traces.9.svg
>
>
> See parent issue for patch and evidence.
> I was looking at graphs of our scan and found that methods were 'too big' to
> be inlined (looking at jvm compilation and inlining output flags -- see
> parent for list). Changing method size helped some. Let me commit the
> resultant patch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
