[
https://issues.apache.org/jira/browse/HBASE-13307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14499356#comment-14499356
]
Hadoop QA commented on HBASE-13307:
-----------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12726061/13307v7.txt
against master branch at commit 7fb6055ed7304b05a383a730b64e55e41772bcf8.
ATTACHMENT ID: 12726061
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13730//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13730//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13730//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13730//console
This message is automatically generated.
> Making methods under ScannerV2#next inlineable, faster
> ------------------------------------------------------
>
> Key: HBASE-13307
> URL: https://issues.apache.org/jira/browse/HBASE-13307
> Project: HBase
> Issue Type: Sub-task
> Components: Scanners
> Reporter: stack
> Assignee: stack
> Fix For: 2.0.0, 1.1.0
>
> Attachments: 13307.txt, 13307v2.branch-1.txt, 13307v3.branch-1.txt,
> 13307v4.branch-1.txt, 13307v5.branch-1.txt, 13307v6.branch-1.txt,
> 13307v6.txt, 13307v7.txt, cpu.png, gc.png, next.png, traces.8.svg,
> traces.9.svg
>
>
> See parent issue for patch and evidence.
> I was looking at graphs of our scan and found that methods were 'too big' to
> be inlined (looking at jvm compilation and inlining output flags -- see
> parent for list). Changing method size helped some. Let me commit the
> resultant patch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
