[
https://issues.apache.org/jira/browse/HBASE-13481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14500400#comment-14500400
]
Enis Soztutar commented on HBASE-13481:
---------------------------------------
bq. those overrides intentional?
yes. Coming from eclipse auto-correction.
bq.I'm not sure if getHostname(Configuration conf, String masterOrRS) is the
right way to do it. perhaps change to boolean isMaster or something like that.
done
bq. More info on my last comment. It seems that the useThisHostnameInstead
logic in HRegionServer will break if it is a master.
Good point. I have added "hbase.master.hostname" parameter for HBASE-12954. Why
do you think it will break? hostname should not be affected of the bind
configurations.
> Master should respect master (old) DNS/bind related configurations
> ------------------------------------------------------------------
>
> Key: HBASE-13481
> URL: https://issues.apache.org/jira/browse/HBASE-13481
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 2.0.0, 1.0.1, 1.1.0
>
> Attachments: hbase-13481_v1.patch, hbase-13481_v2.patch
>
>
> This is a continuation of parent HBASE-13453. We should continue respecting
> the following parameters that 1.0.0 does not:
> {code}
> hbase.master.dns.interface
> hbase.master.dns.nameserver
> hbase.master.ipc.address
> {code}
> Credit goes to [~jerryhe] for pointing that out.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
