[
https://issues.apache.org/jira/browse/HBASE-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119822#comment-13119822
]
[email protected] commented on HBASE-4534:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2155/#review2297
-----------------------------------------------------------
Cool stuff... See below on potential performance concern.
src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java
<https://reviews.apache.org/r/2155/#comment5296>
On many JVMs (including hotspot) this creates a memory barrier.
This might actually cause a measurable slowdown on multi-core machines.
(And maybe I'm just too paranoid).
- Lars
On 2011-10-03 21:59:42, Mikhail Bautin wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2155/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-03 21:59:42)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. A randomized unit test for Gets/Scans (all-row, single-row, multi-row,
all-column, single-column, and multi-column). Also all combinations of Bloom
filters and compression (NONE vs GZIP) are tested. The unit test flushes
multiple StoreFiles with disjoint timestamp ranges and runs various types of
queries against them. Currently we are not testing overlapping timestamp ranges.
bq.
bq.
bq. This addresses bug HBASE-4534.
bq. https://issues.apache.org/jira/browse/HBASE-4534
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java
3ec1962
bq. src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
ede42b2
bq. src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java a828846
bq.
src/test/java/org/apache/hadoop/hbase/regionserver/TestMultiColumnScanner.java
a0d8abf
bq.
src/test/java/org/apache/hadoop/hbase/regionserver/TestScanWithBloomError.java
e86c1c6
bq.
src/test/java/org/apache/hadoop/hbase/regionserver/TestSeekOptimizations.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/2155/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Re-running the test suite. Please do not commit yet.
bq.
bq.
bq. Thanks,
bq.
bq. Mikhail
bq.
bq.
> A new unit test for lazy seek and StoreScanner in general
> ---------------------------------------------------------
>
> Key: HBASE-4534
> URL: https://issues.apache.org/jira/browse/HBASE-4534
> Project: HBase
> Issue Type: Test
> Affects Versions: 0.94.0
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
>
> A randomized unit test for Gets/Scans (all-row, single-row, multi-row,
> all-column, single-column, and multi-column). Also all combinations of Bloom
> filters and compression (NONE vs GZIP) are tested. The unit test flushes
> multiple StoreFiles with disjoint timestamp ranges and runs various types of
> queries against them. Currently we are not testing overlapping timestamp
> ranges.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
