[
https://issues.apache.org/jira/browse/HBASE-13598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520581#comment-14520581
]
Jerry He commented on HBASE-13598:
----------------------------------
Hi, [~stack]
Thanks for the background.
bq. The thought was that no one cared for the tgz being built each time they
ran mvn install – especially when it took a little while to create.
This is the part that confuses me. maven still eludes me from time to time ...
I did some testing after changing the 'attach' to 'true' in hbase-assembly
1) mvn clean install -DskipTests --> This does not build the hbase assembly
tarball nor install it.
2) mvn package assembly:single -DskipTests --> This builds the tarball
mvn install -DskipTests --> This does not install the tarball, even it
was built in the previous step
3) mvn clean package assembly:single install -DskipTests --> This builds the
assembly tarball and install it.
Having the 'attach' to 'false' only makes a difference in 3). The assembly
tarball will not be installed if 'attach' is 'false'.
So the fact that this 'attach' is 'true' does not 'bind' the assembly goal to a
lifecycle phase (i.e. package phase). You still need to call out
'assembly:single' explicitly in the command line.
> Make hbase assembly 'attach' to the project
> -------------------------------------------
>
> Key: HBASE-13598
> URL: https://issues.apache.org/jira/browse/HBASE-13598
> Project: HBase
> Issue Type: Improvement
> Reporter: Jerry He
> Priority: Minor
>
> Currently for hbase assembly, we set 'attach' to 'false':
> hbase-assembly/pom.xml:
> {code}
> <!--We do not want assembly attached; run on command-line explicitly
> - if you want to do an assembly-->
> - <attach>false</attach>
> {code}
> The result is that the hbase assembly tarball will not be deployed via 'mvn
> install' or 'maven deploy'
> There are Apache projects that directly uses the hbase assembly tarball in
> their build process. For example, Slider HBase package and Ambari 2.0
> Metrics.
> Here is the link the maven assembly plug info on the 'attach':
> https://maven.apache.org/plugins/maven-assembly-plugin/single-mojo.html#attach
> {code}
> attach:
> Controls whether the assembly plugin tries to attach the resulting assembly
> to the project.
> Type: boolean
> Since: 2.2-beta-1
> Required: No
> User Property: assembly.attach
> Default: true
> {code}
> The assembly will only be built if 'assembly:single' is specified, and then
> deployed in 'maven install' or 'maven deploy'
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
