[
https://issues.apache.org/jira/browse/HBASE-13598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14522682#comment-14522682
]
Hadoop QA commented on HBASE-13598:
-----------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12729660/HBASE-13598-master.patch
against master branch at commit aabf6ea2f692fc04f02f9a9ce74677bda203647e.
ATTACHMENT ID: 12729660
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+0 tests included{color}. The patch appears to be a
documentation, build,
or dev-support patch that doesn't require tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13903//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13903//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13903//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13903//console
This message is automatically generated.
> Make hbase assembly 'attach' to the project
> -------------------------------------------
>
> Key: HBASE-13598
> URL: https://issues.apache.org/jira/browse/HBASE-13598
> Project: HBase
> Issue Type: Improvement
> Reporter: Jerry He
> Assignee: Jerry He
> Priority: Minor
> Fix For: 2.0.0, 1.2.0
>
> Attachments: HBASE-13598-master.patch
>
>
> Currently for hbase assembly, we set 'attach' to 'false':
> hbase-assembly/pom.xml:
> {code}
> <!--We do not want assembly attached; run on command-line explicitly
> - if you want to do an assembly-->
> - <attach>false</attach>
> {code}
> The result is that the hbase assembly tarball will not be deployed via 'mvn
> install' or 'maven deploy'
> There are Apache projects that directly uses the hbase assembly tarball in
> their build process. For example, Slider HBase package and Ambari 2.0
> Metrics.
> Here is the link the maven assembly plug info on the 'attach':
> https://maven.apache.org/plugins/maven-assembly-plugin/single-mojo.html#attach
> {code}
> attach:
> Controls whether the assembly plugin tries to attach the resulting assembly
> to the project.
> Type: boolean
> Since: 2.2-beta-1
> Required: No
> User Property: assembly.attach
> Default: true
> {code}
> The assembly will only be built if 'assembly:single' is specified, and then
> deployed in 'maven install' or 'maven deploy'
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
