[
https://issues.apache.org/jira/browse/HBASE-13251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14526585#comment-14526585
]
li xiang commented on HBASE-13251:
----------------------------------
Hi all, the following changes are included into HBASE-13251-v1.patch. Only one
change(the first one) is made onto
hbase-protocol/src/main/java/org/apache/hadoop/hbase/util/ByteStringer.java,
others are made onto src/main/asciidoc/_chapters/mapreduce.adoc.
Please review. THANKS!
(1) Relative big changes or corrections
A. Correct HBASE-1304 into HBASE-10304 in the comments of
hbase-protocol/src/main/java/org/apache/hadoop/hbase/util/ByteStringer.java
/**
* Hack to workaround HBASE-10304 issue that keeps bubbling up when a
mapreduce context.
*/
B. Change "Notice to MapReduce users of HBase 0.96.1 and above" into "Notice to
MapReduce users of HBase between 0.96.1 and 0.98.4".
Because HBASE-11118 is applied since 0.98.4, which drops the use of
HBaseZeroCopyByteString, so there is no such issue since 0.98.4.
C. Add "The recommended approach is to let HBase add its dependency jars itself
and use `HADOOP_CLASSPATH` or `-libjars`." between paragraph 2 and 3.
That is to emphasize which is recommended, as a summary of the whole Chapter
44. It should be more clear I believe.
(2) Small corrections
A. Remove the following duplicated expressions
--> you could add hbase-site.xml to the $HADOOP_HOME/conf/ directory and add
the HBase JARs to the HADOOP_HOME/conf/ directory, then copy these changes
across your cluster.
B. Add "/" between "$HADOOP_HOME" and "conf", to make it as
You would then need to copy these changes across your cluster or edit
$HADOOP_HOME/conf/hadoop-env.sh and add them to the HADOOP_CLASSPATH variable.
C. Add "." between "against a table named usertable" and "If you have not...",
to make it as
The following example runs the bundled HBase RowCounter MapReduce job against a
table named usertable. If you have not set the environment variables expected
in the command (the parts prefixed by a $ sign and curly braces),
D. Add "lib/" between "${HBASE_HOME}/hbase-server-VERSION.jar", to make it as
$ HADOOP_CLASSPATH=`${HBASE_HOME}/bin/hbase classpath`
${HADOOP_HOME}/bin/hadoop jar ${HBASE_HOME}/lib/hbase-server-VERSION.jar
rowcounter usertable
E. Regarding the command to use the HBase JARs from the target/directory within
the build environment, change HBASE_HOME into HBASE_BUILD_HOME, to make it as
$
HADOOP_CLASSPATH=${HBASE_BUILD_HOME}/hbase-server/target/hbase-server-VERSION-SNAPSHOT.jar:`${HBASE_BUILD_HOME}/bin/hbase
classpath` ${HADOOP_HOME}/bin/hadoop jar
${HBASE_BUILD_HOME}/hbase-server/target/hbase-server-VERSION-SNAPSHOT.jar
rowcounter usertable
(3) refinements
A. Change "the parts prefixed by a $ sign and curly braces" into "the parts
prefixed by a $ sign and surrounded by curly braces"
B. Change "setting the CLASSPATH as part of the command" into "setting the
output of hbase classpath (the command to dump HBase CLASSPATH) to
HADOOP_CLASSPATH"
> Correct 'HBase, MapReduce, and the CLASSPATH' section in HBase Ref Guide
> ------------------------------------------------------------------------
>
> Key: HBASE-13251
> URL: https://issues.apache.org/jira/browse/HBASE-13251
> Project: HBase
> Issue Type: Improvement
> Components: documentation
> Reporter: Jerry He
> Attachments: HBASE-13251-v1.patch
>
>
> As [~busbey] pointed out in HBASE-13149, we have a section "HBase, MapReduce,
> and the CLASSPATH" in the HBase Ref Guide.
> http://hbase.apache.org/book.html#hbase.mapreduce.classpath
> There are duplication, errors and misinformation in the section.
> Need to cleanup and polish it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
