[ 
https://issues.apache.org/jira/browse/HBASE-13251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14528678#comment-14528678
 ] 

Hadoop QA commented on HBASE-13251:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12730489/HBASE-13251-v2.patch
  against master branch at commit 977f867439e960c668ee6311e47c904efc40f219.
  ATTACHMENT ID: 12730489

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+0 tests included{color}.  The patch appears to be a 
documentation patch that doesn't require tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +To give the MapReduce jobs the access they need, you could add 
_hbase-site.xml_ to _$HADOOP_HOME/conf_ and add HBase jars to the 
_$HADOOP_HOME/lib_ directory.
+You would then need to copy these changes across your cluster or edit 
_$HADOOP_HOME/conf/hadoop-env.sh_ and add them to the `HADOOP_CLASSPATH` 
variable.
+The recommended approach is to let HBase add its dependency jars itself and 
use `HADOOP_CLASSPATH` or `-libjars`.
+The following example runs the bundled HBase 
link:http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/mapreduce/RowCounter.html[RowCounter]
 MapReduce job against a table named `usertable`.
+If you have not set the environment variables expected in the command (the 
parts prefixed by a `$` sign and surrounded by curly braces), you can use the 
actual system paths instead.
+The backticks (``` symbols) cause ths shell to execute the sub-commands, 
setting the output of `hbase classpath` (the command to dump HBase CLASSPATH) 
to `HADOOP_CLASSPATH`.
+$ HADOOP_CLASSPATH=`${HBASE_HOME}/bin/hbase classpath` 
${HADOOP_HOME}/bin/hadoop jar ${HBASE_HOME}/lib/hbase-server-VERSION.jar 
rowcounter usertable
+The command of `hbase mapredcp` can also help you dump the CLASSPATH entries 
required by MapReduce, which are the same jars 
`TableMapReduceUtil#addDependencyJars` would add.
+For jobs that do not package their dependencies or call 
`TableMapReduceUtil#addDependencyJars`, the following command structure is 
necessary:
+$ HADOOP_CLASSPATH=`${HBASE_HOME}/bin/hbase mapredcp`:${HBASE_HOME}/conf 
hadoop jar MyApp.jar MyJobMainClass -libjars $(${HBASE_HOME}/bin/hbase mapredcp 
| tr ':' ',') ...

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13940//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13940//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13940//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13940//console

This message is automatically generated.

> Correct 'HBase, MapReduce, and the CLASSPATH' section in HBase Ref Guide
> ------------------------------------------------------------------------
>
>                 Key: HBASE-13251
>                 URL: https://issues.apache.org/jira/browse/HBASE-13251
>             Project: HBase
>          Issue Type: Improvement
>          Components: documentation
>            Reporter: Jerry He
>            Assignee: li xiang
>              Labels: documentation
>         Attachments: HBASE-13251-v1.patch, HBASE-13251-v2.patch
>
>
> As [~busbey] pointed out in HBASE-13149, we have a section "HBase, MapReduce, 
> and the CLASSPATH" in the HBase Ref Guide.
> http://hbase.apache.org/book.html#hbase.mapreduce.classpath
> There are duplication, errors and misinformation in the section.
> Need to cleanup and polish it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to