[
https://issues.apache.org/jira/browse/HBASE-13562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14528427#comment-14528427
]
Ashish Singhi commented on HBASE-13562:
---------------------------------------
Attached patch for master interface all the permissions test which are in To be
tested column in the below table or which I could not find any test case.
The row which has has empty column for To be tested means the existing test
case already covers all the permission check for it.
||Operation||Permissions||Existing Test Case||To be tested
|createTable|superuser\|global(C)\|NS(C)|TNC#testCreateTableWithNamespace,
TAC#testTableCreate|
|modifyTable|superuser\|global(A)\|global(C)\|NS(A)\|NS(C)\|table(A)\|table(C)|TAC#testTableModify|table(A),
NS(A), NS(C)
|deleteTable|superuser\|global(A)\|global(C)\|NS(A)\|NS(C)\|table(A)\|table(C)|TAC#testTableDelete|table(A),
NS(A), NS(C)
|truncateTable|superuser\|global(A)\|global(C)\|NS(A)\|NS(C)\|table(A)\|table(C)|TAC#testTableTruncate|table(A),
NS(A), NS(C)
|addColumn|superuser\|global(A)\|global(C)\|NS(A)\|NS(C)\|table(A)\|table(C)|TAC#testAddColumn|table(A),
NS(A), NS(C)
|modifyColumn|superuser\|global(A)\|global(C)\|NS(A)\|NS(C)\|table(A)\|table(C)\|column(A)\|column(C)|TAC#testModifyColumn|table(A),
NS(A), NS(C)
|deleteColumn|superuser\|global(A)\|global(C)\|NS(A)\|NS(C)\|table(A)\|table(C)\|column(A)\|column(C)|TAC#testDeleteColumn|table(A),
NS(A), NS(C)
|enableTable|superuser\|global(A)\|global(C)\|NS(A)\|NS(C)\|table(A)\|table(C)|TAC#testTableEnable|table(A),
NS(A), NS(C)
|disableTable|superuser\|global(A)\|global(C)\|NS(A)\|NS(C)\|table(A)\|table(C)|TAC#testTableDisable|table(A),
NS(A), NS(C)
|disableAclTable|Not allowed|TAC#testTableDisable|
|move|superuser\|global(A)\|NS(A)\|Table(A)|TAC#testMove|table(A), NS(A)
|assign|superuser\|global(A)\|NS(A)\|Table(A)|TAC#testAssign|table(A), NS(A)
|unassign|superuser\|global(A)\|NS(A)\|Table(A)|TAC#testUnassign|table(A), NS(A)
|regionOffline|superuser\|global(A)\|NS(A)\|Table(A)|TAC#testRegionOffline|table(A),
NS(A)
|balance|superuser\|global(A)|TAC#testBalance|
|balanceSwitch|superuser\|global(A)|TAC#testBalanceSwitch|
|shutdown|superuser\|global(A)|TAC#testShutdown|
|stopMaster|superuser\|global(A)|TAC#testStopMaster|
|snapshot|superuser\|global(A)\|NS(A)\|Table(A)|TAC#testSnapShot|
|listSnapshot|superuser\|global(A)\|SnapshotOwner|
|superuser\|global(A)\|SnapshotOwner
|cloneSnapshot|superuser\|global(A)|TAC#testSnapShot|
|restoreSnapshot|superuser\|global(A)\|SnapshotOwner &
(NS(A)\|Table(A))|TAC#testSnapShot, TAC#testSnapshotWithOwner|
|deleteSnapshot|superuser\|global(A)\|SnapshotOwner|TAC#testSnapShot,
TAC#testSnapshotWithOwner|
|createNamespace|superuser\|global(A)|TNC#testCreateAndDeleteNamespace|
|deleteNamespace|superuser\|global(A)|TNC#testCreateAndDeleteNamespace|
|modifyNamespace|superuser\|global(A)|TNC#testModifyNamespace|
|getNamespaceDescriptor|superuser\|global(A)\|NS(A)|TNC#testGetNamespaceDescriptor|
|listNamespaceDescriptors*|superuser\|global(A)\|NS(A)|
|superuser\|global(A)\|NS(A)
|flushTable|superuser\|global(A)\|global(C)\|NS(A)\|NS(\C)\|table(A)\|table(C)|
|superuser\|global(A)\|global(C)\|NS(A)\|NS(\C)\|table(A)\|table(C)
|getTableDescriptors*|superuser\|global(A)\|global(C)\|NS(A)\|NS(C)\|table(A)\|table(C)|
|superuser\|global(A)\|global(C)\|NS(A)\|NS(C)\|table(A)\|table(C)
|getTableNames*|Any global or table perm| |
|setUserQuota(global level)|superuser\|global(A)|TAC#testSetQuota|
|setUserQuota(namespace level)|superuser\|global(A)|TAC#testSetQuota|
|setUserQuota(Table
level)|superuser\|global(A)\|NS(A)\|Table(A)|TAC#testSetQuota|NS(A), Table(A)
|setTableQuota|superuser\|global(A)\|NS(A)\|Table(A)|TAC#testSetQuota|NS(A),
Table(A)
|setNamespaceQuota|superuser\|global(A)|TAC#testSetQuota|
> Add testing coverage to AccessController for all combinations of scope and
> permissions.
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-13562
> URL: https://issues.apache.org/jira/browse/HBASE-13562
> Project: HBase
> Issue Type: Improvement
> Reporter: Srikanth Srungarapu
> Assignee: Ashish Singhi
> Attachments: HBASE-13562.patch
>
>
> As of now, the tests in TestAccessController and TestAccessController2
> doesn't cover all the combinations of Scope and Permissions. Ideally, we
> should have testing coverage for the entire [ACL
> matrix|https://hbase.apache.org/book/appendix_acl_matrix.html].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
