[ 
https://issues.apache.org/jira/browse/HBASE-13562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14528444#comment-14528444
 ] 

Ashish Singhi commented on HBASE-13562:
---------------------------------------

In the above TAC stands for TestAccessController.java and TNC for 
TestNamespaceCommands.java.

For Master interface (till now I have checked this only) mainly namespace 
permissions and table admin permission tests were missing.
I have added all the missing namespace permission test in TestNamespaceCommands 
class.

Also I feel its better to break this jira based on the ACL matric interface, so 
that developing and reviewing the patch also becomes easy.
Please review and let me know your thought, based on that I will move this jira 
into Patch Available state.

> Add testing coverage to AccessController for all combinations of scope and 
> permissions.
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-13562
>                 URL: https://issues.apache.org/jira/browse/HBASE-13562
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Srikanth Srungarapu
>            Assignee: Ashish Singhi
>         Attachments: HBASE-13562.patch
>
>
> As of now, the tests in TestAccessController and TestAccessController2 
> doesn't cover all the combinations of Scope and Permissions. Ideally, we 
> should have testing coverage for the entire [ACL 
> matrix|https://hbase.apache.org/book/appendix_acl_matrix.html].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to