[
https://issues.apache.org/jira/browse/HBASE-13562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537166#comment-14537166
]
Hadoop QA commented on HBASE-13562:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12731789/HBASE-13562_v2.patch
against master branch at commit 5a2ca43fa16a95d8db67e5a3d8b48e4d3f3a9aeb.
ATTACHMENT ID: 12731789
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 27 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ .preDeleteTable(ObserverContext.createAndPrepare(CP_ENV,
null), TEST_TABLE.getTableName());
+
ACCESS_CONTROLLER.preAddColumn(ObserverContext.createAndPrepare(CP_ENV, null),
TEST_TABLE.getTableName(),
+ .preEnableTable(ObserverContext.createAndPrepare(CP_ENV, null),
TEST_TABLE.getTableName());
+ final List<HRegion> regions =
TEST_UTIL.getHBaseCluster().findRegionsForTable(TEST_TABLE.getTableName());
+ .bulkLoadHFile(TEST_TABLE.getTableName(), TEST_FAMILY,
TEST_QUALIFIER, hfileRanges, numRows);
+ private boolean hasFoundUserPermission(UserPermission userPermission,
List<UserPermission> perms) {
+ grantOnTableUsingAccessControlClient(TEST_UTIL, systemUserConnection,
testGrantRevoke.getShortName(),
+ revokeFromTableUsingAccessControlClient(TEST_UTIL, systemUserConnection,
testGrantRevoke.getShortName(),
+ grantOnNamespaceUsingAccessControlClient(TEST_UTIL,
systemUserConnection, testNS.getShortName(),
+ revokeFromNamespaceUsingAccessControlClient(TEST_UTIL,
systemUserConnection, testNS.getShortName(),
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13999//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13999//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13999//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13999//console
This message is automatically generated.
> Expand AC testing coverage to include all combinations of scope and
> permissions.
> --------------------------------------------------------------------------------
>
> Key: HBASE-13562
> URL: https://issues.apache.org/jira/browse/HBASE-13562
> Project: HBase
> Issue Type: Improvement
> Reporter: Srikanth Srungarapu
> Assignee: Ashish Singhi
> Attachments: HBASE-13562-v1.patch, HBASE-13562-v2.patch,
> HBASE-13562.patch, HBASE-13562_v2.patch, sample.patch
>
>
> As of now, the tests in TestAccessController and TestAccessController2
> doesn't cover all the combinations of Scope and Permissions. Ideally, we
> should have testing coverage for the entire [ACL
> matrix|https://hbase.apache.org/book/appendix_acl_matrix.html].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
