[
https://issues.apache.org/jira/browse/HBASE-13562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537280#comment-14537280
]
Ashish Singhi commented on HBASE-13562:
---------------------------------------
Thanks for the patch.
I skimmed _v2 patch.
Some comments.
1. There are some unused variables in {{TestAccessControllerNonMasterAndRSOps}}
we can remove them.
2. There are some deprecated methods being used better we can remove them now.
3. One other thing I have noted is we are doing some operations in {{@Before}}
and {{@After}} annotated methods which are not really required to be done
before and after every test run, instead I would suggest to move them in
{{@BeforeClass}} and {{@AfterClass}} annotated methods respectively.
Two days back when I was working on {{TestAccessController}} class I noted this
and when I modified the test accordingly locally I saw that the test run time
was 3x times better! I thought of contributing this as part of other jira as it
was out of this jira scope. But since now the test class is completely
rewritten I would suggest we can accommodate the change here itself.
If you are busy with some other stuff, just let me know I can work upon them.
May be we can raise a umbrella ticket for test run time improvement and check
other test classes as well.
> Expand AC testing coverage to include all combinations of scope and
> permissions.
> --------------------------------------------------------------------------------
>
> Key: HBASE-13562
> URL: https://issues.apache.org/jira/browse/HBASE-13562
> Project: HBase
> Issue Type: Improvement
> Reporter: Srikanth Srungarapu
> Assignee: Ashish Singhi
> Attachments: HBASE-13562-v1.patch, HBASE-13562-v2.patch,
> HBASE-13562.patch, HBASE-13562_v2.patch, sample.patch
>
>
> As of now, the tests in TestAccessController and TestAccessController2
> doesn't cover all the combinations of Scope and Permissions. Ideally, we
> should have testing coverage for the entire [ACL
> matrix|https://hbase.apache.org/book/appendix_acl_matrix.html].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
