[
https://issues.apache.org/jira/browse/HBASE-13510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537655#comment-14537655
]
Anoop Sam John commented on HBASE-13510:
----------------------------------------
We have 2 impls for BloomFilter interface. ie. CompoundBloomFilter and
ByteBloomFilter.
We are not at all using ByteBloomFilter.(Which is having diff way of dealing
with ROW_COL bloom key). This was there in use for HFileV1 I believe. So we
can do those cleanup also. We no loner need ByteBloomFilter as is a
BloomFilter. This class was having some util methods which now moved to a Util
class (static methods)... Still ByteBloomFilter is in use and used to store
some state(in this patch) .Can we avoid it fully ?
> Refactor Bloom filters to make use of Cell Comparators in case of ROW_COL
> -------------------------------------------------------------------------
>
> Key: HBASE-13510
> URL: https://issues.apache.org/jira/browse/HBASE-13510
> Project: HBase
> Issue Type: Sub-task
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 2.0.0
>
> Attachments: HBASE-13510_1.patch, HBASE-13510_2.patch
>
>
> In order to address the comments over in HBASE-10800 related to comparing
> Cell with a serialized KV's key we had some need for that in Bloom filters.
> After discussing with Anoop, we found that it may be possible to
> remove/modify some of the APIs in the BloomFilter interfaces and for doing
> that we can purge ByteBloomFilter.
> I read the code and found that ByteBloomFilter was getting used in V1 version
> only. Now as it is obsolete we can remove this code and move some of the
> static APIs in ByteBloomFilter to some other util class or bloom related
> classes which will help us in refactoring the code too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
