[
https://issues.apache.org/jira/browse/HBASE-13510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538188#comment-14538188
]
ramkrishna.s.vasudevan commented on HBASE-13510:
------------------------------------------------
bq.We have 2 impls for BloomFilter interface. ie. CompoundBloomFilter and
ByteBloomFilter.
{code}
public class ByteBloomFilter implements BloomFilter, BloomFilterWriter {
{code}
Now this patch removes this and now it is
{code}
public class ByteBloomFilter implements BloomFilterBase {
{code}
This bloomFilterBase now has getKeyCount, getMaxKeys and getByteSize(). May be
shall we just change the name of the ByteBloomfilter so that we don't see it as
a type of Bloomfilter? Now it basically acts as the building block for
CompoundbloomFilter.
> Refactor Bloom filters to make use of Cell Comparators in case of ROW_COL
> -------------------------------------------------------------------------
>
> Key: HBASE-13510
> URL: https://issues.apache.org/jira/browse/HBASE-13510
> Project: HBase
> Issue Type: Sub-task
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 2.0.0
>
> Attachments: HBASE-13510_1.patch, HBASE-13510_2.patch
>
>
> In order to address the comments over in HBASE-10800 related to comparing
> Cell with a serialized KV's key we had some need for that in Bloom filters.
> After discussing with Anoop, we found that it may be possible to
> remove/modify some of the APIs in the BloomFilter interfaces and for doing
> that we can purge ByteBloomFilter.
> I read the code and found that ByteBloomFilter was getting used in V1 version
> only. Now as it is obsolete we can remove this code and move some of the
> static APIs in ByteBloomFilter to some other util class or bloom related
> classes which will help us in refactoring the code too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
