[ 
https://issues.apache.org/jira/browse/HBASE-13344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544560#comment-14544560
 ] 

Sean Busbey commented on HBASE-13344:
-------------------------------------

{quote}
Don't we already check Java min version? I might just be slow, but why this 
extra check? Does it make the existing enforcer rule redundant?
{quote}

this sets a _maximum_ jdk version, to ensure we don't generate byte code that 
won't work with whatever our oldest supported JVM version.

{quote}
We've had Java 8 builds of master running unit tests in house for a while and I 
think that, even with this patch, Sean Busbey, things would be fine as long as 
-DcompileSource is passed to the mvn command (to override 1.7 in the pom.xml).
{quote}

Okay good. Anyone specifically want us to test build-with-7-then-run-with-8?

> Add enforcer rule that matches our JDK support statement
> --------------------------------------------------------
>
>                 Key: HBASE-13344
>                 URL: https://issues.apache.org/jira/browse/HBASE-13344
>             Project: HBase
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 2.0.0
>            Reporter: Sean Busbey
>            Assignee: Matt Warhaftig
>            Priority: Minor
>              Labels: beginner, maven
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13344-master.patch
>
>
> The [ref guide gives a list of JDKs that we expect our hbase versions to work 
> with at runtime|http://hbase.apache.org/book.html#basic.prerequisites].
> Let's add in the extra-enforcer-rules mojo and start using [the bytecode 
> version  
> rule|http://mojo.codehaus.org/extra-enforcer-rules/enforceBytecodeVersion.html]
>  to make sure that the result of our builds on a given branch won't fail out 
> because of a misconfigured target jdk version (or a dependency that targets a 
> later jdk).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to