[
https://issues.apache.org/jira/browse/HBASE-13344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14557460#comment-14557460
]
Sean Busbey commented on HBASE-13344:
-------------------------------------
No, I think it's fine targeting master. The only thing I'm worried about is
making sure there's enough information for folks who have java 8 to correct
things and build.
{code}
+ <enforceBytecodeVersion>
+ <maxJdkVersion>${compileSource}</maxJdkVersion>
+ <message>HBase has unsupported dependencies.
+ HBase requires that all dependencies be compiled with version
${compileSource} or earlier
+ of the JDK to properly build from source. You appear to be using a newer
dependency. You can use
+ either "mvn -version" or "mvn enforcer:display-info" to verify what version
is active.
+ </message>
+ </enforceBytecodeVersion>
{code}
Could you add one more quick note here, along the lines of "So long as you are
not doing a release build, you can temporarily enable building with a newer JDK
version by setting the 'compileSource' property. E.g 'mvn -DcompileSource=1.8
clean package'."
> Add enforcer rule that matches our JDK support statement
> --------------------------------------------------------
>
> Key: HBASE-13344
> URL: https://issues.apache.org/jira/browse/HBASE-13344
> Project: HBase
> Issue Type: Improvement
> Components: build
> Affects Versions: 2.0.0
> Reporter: Sean Busbey
> Assignee: Matt Warhaftig
> Priority: Minor
> Labels: beginner, maven
> Fix For: 2.0.0
>
> Attachments: HBASE-13344-master.patch
>
>
> The [ref guide gives a list of JDKs that we expect our hbase versions to work
> with at runtime|http://hbase.apache.org/book.html#basic.prerequisites].
> Let's add in the extra-enforcer-rules mojo and start using [the bytecode
> version
> rule|http://mojo.codehaus.org/extra-enforcer-rules/enforceBytecodeVersion.html]
> to make sure that the result of our builds on a given branch won't fail out
> because of a misconfigured target jdk version (or a dependency that targets a
> later jdk).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
