[
https://issues.apache.org/jira/browse/HBASE-13510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14546317#comment-14546317
]
stack commented on HBASE-13510:
-------------------------------
Fix this formatting...
501 if (qualifier == null)
502 qualifier = DUMMY;
and what is DUMMY? You mean empty? (Anoop said use EMPTY_BYTES from
HConstants)
Yeah, I don't get why we can't go to Cell since blooms are hashes... but Anoop
does above so that is enough for me (for now -- smile)
The javadoc on BloomFilterChunk is about BloomFilters. Is BFC a BF or utility a
BF could use to make chunks? In javadoc, we don't say what a BFC is. If it is a
BF, then why not call it so? We have a BF in our code base already and it has
javadoc on the class that is similar to what is here. How does a BFC relate to
a BF.
Man, BloomFilterBase is and Interface? That'll throw folks off.
Having a bit of a hard time navigating the hierarchy here with BloomFilter and
BloomFilterBase and BloomFilterChunk. ByteBloomFilter seems like a better name
than BFC yet we are removing it and putting in place a new class named BFC that
has a good bit of BBF. You don't want to just purge the unused bits from BBF?
> Purge ByteBloomFilter
> ---------------------
>
> Key: HBASE-13510
> URL: https://issues.apache.org/jira/browse/HBASE-13510
> Project: HBase
> Issue Type: Sub-task
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 2.0.0
>
> Attachments: HBASE-13510_1.patch, HBASE-13510_2.patch,
> HBASE-13510_3.patch
>
>
> In order to address the comments over in HBASE-10800 related to comparing
> Cell with a serialized KV's key we had some need for that in Bloom filters.
> After discussing with Anoop, we found that it may be possible to
> remove/modify some of the APIs in the BloomFilter interfaces and for doing
> that we can purge ByteBloomFilter.
> I read the code and found that ByteBloomFilter was getting used in V1 version
> only. Now as it is obsolete we can remove this code and move some of the
> static APIs in ByteBloomFilter to some other util class or bloom related
> classes which will help us in refactoring the code too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
