[ 
https://issues.apache.org/jira/browse/HBASE-13510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14546872#comment-14546872
 ] 

stack commented on HBASE-13510:
-------------------------------

bq. Ya we could try that may be rewrite the hash function to pick the 
individual bytes from the Cell's components like row, fam etc.

Yes. We need to do this as part of the move to Cell effort, right? Could be in 
a follow-on issue.

BloomChunk is a better name.

bq. When we started this offheap and came to this BLOOM I am finding it 
difficult to make this hierarchy more easier.

Understood.

Let me look at the latest patch.





> Purge ByteBloomFilter
> ---------------------
>
>                 Key: HBASE-13510
>                 URL: https://issues.apache.org/jira/browse/HBASE-13510
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13510_1.patch, HBASE-13510_2.patch, 
> HBASE-13510_3.patch, HBASE-13510_5.patch
>
>
> In order to address the comments over in HBASE-10800 related to comparing 
> Cell with a serialized KV's key we had some need for that in Bloom filters.  
> After discussing with Anoop, we found that it may be possible to 
> remove/modify some of the APIs in the BloomFilter interfaces and for doing 
> that we can purge ByteBloomFilter.  
> I read the code and found that ByteBloomFilter was getting used in V1 version 
> only.  Now as it is obsolete we can remove this code and move some of the 
> static APIs in ByteBloomFilter to some other util class or bloom related 
> classes which will help us in refactoring the code too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to