[
https://issues.apache.org/jira/browse/HBASE-13531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14550146#comment-14550146
]
Anoop Sam John commented on HBASE-13531:
----------------------------------------
Looks good overall.
Some minor comments
SweepReducer - Can we close the StoreFileScanner also?
ReversedMobStoreScanner extend MobStoreScanner. So u can make the readPt state
in MobStoreScanner to be protected so as to avoid define again and set in
ReversedMobStoreScanner .
MobFileCache
{code}
public MobFile openFile(FileSystem fs, Path path, MobCacheConfig cacheConf)
throws IOException {
if (!isCacheEnabled) {
- return MobFile.create(fs, path, conf, cacheConf);
+ MobFile mobFile = MobFile.create(fs, path, conf, cacheConf);
+ mobFile.open();
+ return mobFile;
{code}
Pls check and make sure the callers are closing this file after the use.
> After 4/18/15 merge, flakey failures of
> TestAcidGuarantees#testMobScanAtomicity
> -------------------------------------------------------------------------------
>
> Key: HBASE-13531
> URL: https://issues.apache.org/jira/browse/HBASE-13531
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver, Scanners
> Affects Versions: hbase-11339
> Reporter: Jonathan Hsieh
> Assignee: Jingcheng Du
> Fix For: hbase-11339
>
> Attachments: HBASE-13531-V2.diff, HBASE-13531-V3.diff,
> HBASE-13531-V4.diff, HBASE-13531-V5.diff, HBASE-13531.diff
>
>
> After the merge of master from 4/18/15 with hbase-11339 branch, we encounter
> some atomicity violations. We want to fix before calling merge to trunk.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
