[
https://issues.apache.org/jira/browse/HBASE-13531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14550158#comment-14550158
]
Jingcheng Du commented on HBASE-13531:
--------------------------------------
Thanks [~anoopsamjohn] for the comment!
bq. SweepReducer - Can we close the StoreFileScanner also?
Sure, add it back in the latest patch.
bq.ReversedMobStoreScanner extend MobStoreScanner. So u can make the readPt
state in MobStoreScanner to be protected so as to avoid define again and set in
ReversedMobStoreScanner
Change the readPt to protected in StoreScanner, and remove the ones in
MobStoreScanner and ReversedMobStoreScanner.
bq. Pls check and make sure the callers are closing this file after the use.
Right. This is only internal used. We have guaranteed the right usages in the
code.
> After 4/18/15 merge, flakey failures of
> TestAcidGuarantees#testMobScanAtomicity
> -------------------------------------------------------------------------------
>
> Key: HBASE-13531
> URL: https://issues.apache.org/jira/browse/HBASE-13531
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver, Scanners
> Affects Versions: hbase-11339
> Reporter: Jonathan Hsieh
> Assignee: Jingcheng Du
> Fix For: hbase-11339
>
> Attachments: HBASE-13531-V2.diff, HBASE-13531-V3.diff,
> HBASE-13531-V4.diff, HBASE-13531-V5.diff, HBASE-13531.diff
>
>
> After the merge of master from 4/18/15 with hbase-11339 branch, we encounter
> some atomicity violations. We want to fix before calling merge to trunk.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
