[
https://issues.apache.org/jira/browse/HBASE-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14561321#comment-14561321
]
Nick Dimiduk commented on HBASE-13761:
--------------------------------------
Patch v5 mangles the ASL headers on all the files; let's get that fixed on
commit.
Nit: doc strings on private variables can be made into javadoc compatible
docstrings, and then their content will be provided inline by IDEs (ie,
{{FuzzyRowFilter#tracker}}).
Can the {{satisfies}} and {{satisfiesNoUnsafe}} methods be made non-public?
Package protected? I don't want that creeping into the public API of this class.
{{UnsafeAccess}} should be {{@InterfaceAudience.Private}}
Can you parameterize the test to run both with and without Unsafe, so make sure
the two implementations have feature parity?
All these tests were wrong, or is it the semantics of satisfies are changed?
This is great stuff [~vrodionov].
> Optimize FuzzyRowFilter
> -----------------------
>
> Key: HBASE-13761
> URL: https://issues.apache.org/jira/browse/HBASE-13761
> Project: HBase
> Issue Type: Improvement
> Components: Filters
> Affects Versions: 2.0.0, 1.1.0, 0.98.13
> Reporter: Vladimir Rodionov
> Assignee: Vladimir Rodionov
> Priority: Minor
> Fix For: 2.0.0, 0.98.14, 1.1.1
>
> Attachments: HBASE-13761-0.98.patch, HBASE-13761.patch,
> HBASE-13761_2.patch, HBASE-13761_4.patch, HBASE-13761_5.patch
>
>
> FuzzyRowFilter has some room for improvements: a lot of byte-by-byte
> arithmetic, non-efficient algorithm of selecting next candidate row etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
