[
https://issues.apache.org/jira/browse/HBASE-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14561383#comment-14561383
]
Nick Dimiduk commented on HBASE-13761:
--------------------------------------
{quote}
bq. All these tests were wrong, or is it the semantics of satisfies are changed?
Not sure I am following you here, but semantics of satisfies has been changed.
Now it always return either YES or NEXT_EXISTS. Even if there are no more rows
(NO_NEXT in old version) we are OK because getNextCellHint in this case will
return null.
{quote}
Okay, makes sense.
{quote}
bq. Can you elaborate on this:
Nit: doc strings on private variables can be made into javadoc compatible
docstrings, and then their content will be provided inline by IDEs (ie,
FuzzyRowFilter#tracker).
{quote}
Meaning, use {{/\*\*}} as comment prefix instead of {{/\*}} so that the javadoc
parser will pick up your nice variable descriptions.
> Optimize FuzzyRowFilter
> -----------------------
>
> Key: HBASE-13761
> URL: https://issues.apache.org/jira/browse/HBASE-13761
> Project: HBase
> Issue Type: Improvement
> Components: Filters
> Affects Versions: 2.0.0, 1.1.0, 0.98.13
> Reporter: Vladimir Rodionov
> Assignee: Vladimir Rodionov
> Priority: Minor
> Fix For: 2.0.0, 0.98.14, 1.2.0, 1.1.1
>
> Attachments: HBASE-13761.patch, HBASE-13761_2.patch,
> HBASE-13761_4.patch, HBASE-13761_5.patch
>
>
> FuzzyRowFilter has some room for improvements: a lot of byte-by-byte
> arithmetic, non-efficient algorithm of selecting next candidate row etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
