[ 
https://issues.apache.org/jira/browse/HBASE-13754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14561458#comment-14561458
 ] 

Anoop Sam John commented on HBASE-13754:
----------------------------------------

Yes looks good 
http://docs.oracle.com/javaee/6/api/javax/resource/cci/Streamable.html 
In initial internal versions, I kept as Streamable kind of and in this patch 
though to name it with Cell in the interface name.  'Streamable ' looks better. 
Will keep the method name as write()  But again, we need the boolean withTags 
!! :-(

> Allow non KeyValue Cell types also to oswrite
> ---------------------------------------------
>
>                 Key: HBASE-13754
>                 URL: https://issues.apache.org/jira/browse/HBASE-13754
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Scanners
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13754.patch
>
>
> While making the cellblock for returning data to client, we have to write the 
> cell data into an OutputStream. KeyValue has a static oswrite() method with 
> which it can write data in one go. (KeyValue components are in a single 
> byte[]). For other cell implementation, we will call getXXXLength() and 
> getXXXArray() and write each component one after the other. This is not 
> efficient as the KeyValue way. In fact other cell impls also may have one 
> contigous byte[] backing for keys atleast. (See ClonedSeekerState) We can 
> optimize for such Cells also.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to