[
https://issues.apache.org/jira/browse/HBASE-13754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14562076#comment-14562076
]
Hadoop QA commented on HBASE-13754:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12735667/HBASE-13754_V2.patch
against master branch at commit 6529d8833d965fb201b9fe6927eed425bf31607f.
ATTACHMENT ID: 12735667
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14204//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14204//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14204//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14204//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14204//console
This message is automatically generated.
> Allow non KeyValue Cell types also to oswrite
> ---------------------------------------------
>
> Key: HBASE-13754
> URL: https://issues.apache.org/jira/browse/HBASE-13754
> Project: HBase
> Issue Type: Sub-task
> Components: Scanners
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Fix For: 2.0.0
>
> Attachments: HBASE-13754.patch, HBASE-13754_V2.patch
>
>
> While making the cellblock for returning data to client, we have to write the
> cell data into an OutputStream. KeyValue has a static oswrite() method with
> which it can write data in one go. (KeyValue components are in a single
> byte[]). For other cell implementation, we will call getXXXLength() and
> getXXXArray() and write each component one after the other. This is not
> efficient as the KeyValue way. In fact other cell impls also may have one
> contigous byte[] backing for keys atleast. (See ClonedSeekerState) We can
> optimize for such Cells also.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
