[
https://issues.apache.org/jira/browse/HBASE-13828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572406#comment-14572406
]
Hadoop QA commented on HBASE-13828:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12737480/HBASE-13828.patch
against master branch at commit bb62d5b2e8db1677568723bb8d0d8ea4fd2c6f46.
ATTACHMENT ID: 12737480
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ verifyAllowed(action, SUPERUSER, USER_ADMIN, USER_OWNER, USER_CREATE,
USER_RW, TESTGROUP_W_USER);
+ verifyDenied(appendAction, USER_RO, USER_NONE, TESTGROUP_C_USER,
TESTGROUP_R_USER,TESTGROUP_A_USER);
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14283//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14283//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14283//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14283//console
This message is automatically generated.
> Add group permissions testing coverage to AC.
> ---------------------------------------------
>
> Key: HBASE-13828
> URL: https://issues.apache.org/jira/browse/HBASE-13828
> Project: HBase
> Issue Type: Improvement
> Reporter: Srikanth Srungarapu
> Assignee: Ashish Singhi
> Attachments: HBASE-13828.patch
>
>
> We suffered a regression HBASE-13826 recently due to lack of testing coverage
> for group permissions for AC. With the recent perf boost provided by
> HBASE-13658, it wouldn't be a bad idea to add checks for group level users to
> applicable unit tests in TestAccessController.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
