[
https://issues.apache.org/jira/browse/HBASE-13828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14580287#comment-14580287
]
Ashish Singhi commented on HBASE-13828:
---------------------------------------
Thanks for the review.
bq. Can we use TEST_GROUP_1 by changing its value to
convertToGroup("testgroup_1") instead of creating a new variable
testGroup1GroupName?
But still then either we need to have local variable with value
{{"testgroup_1"} or use it directly when creating the user(s) for this group.
We are using that name here
{code}
TESTGROUP1_USER1 =
User.createUserForTesting(conf, "testgroup1_user1", new String[] {
TESTGROUP_1 });
{code}
> Add group permissions testing coverage to AC.
> ---------------------------------------------
>
> Key: HBASE-13828
> URL: https://issues.apache.org/jira/browse/HBASE-13828
> Project: HBase
> Issue Type: Improvement
> Reporter: Srikanth Srungarapu
> Assignee: Ashish Singhi
> Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.1
>
> Attachments: HBASE-13828-0.98.patch, HBASE-13828-branch-1.0.patch,
> HBASE-13828-branch-1.1.patch, HBASE-13828-branch-1.patch,
> HBASE-13828-v1.patch, HBASE-13828-v2.patch, HBASE-13828.patch
>
>
> We suffered a regression HBASE-13826 recently due to lack of testing coverage
> for group permissions for AC. With the recent perf boost provided by
> HBASE-13658, it wouldn't be a bad idea to add checks for group level users to
> applicable unit tests in TestAccessController.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
