[ 
https://issues.apache.org/jira/browse/HBASE-13755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577634#comment-14577634
 ] 

Mikhail Antonov commented on HBASE-13755:
-----------------------------------------

Hm.. Actually I would say this constant could be viewed just naturally 
belonging to this class (or at least having it in this class looks not less 
logical than having it in class AccessControlLists to me), as parsing 
hbase-site.xml to populate caches is it's primary purpose? The only other place 
(besides tests) where this constant is used it TableAuthManager.

I'm a bit uncertain here about adding comments explaining why certain stuff is 
placed to certain class - if people think that having this constant in this 
class looks misleading, then supposedly there should be a place where it would 
look much more natural, in which case let's just move it there?

I thought originally about putting it in HConstants, but comment there says 
(rightfully) - "// NOTICE!!!! Please do not add a constants here, unless they 
are referenced by a lot of classes.". Which is not the case here.

> Provide single super user check implementation
> ----------------------------------------------
>
>                 Key: HBASE-13755
>                 URL: https://issues.apache.org/jira/browse/HBASE-13755
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Anoop Sam John
>            Assignee: Mikhail Antonov
>             Fix For: 2.0.0, 1.2.0
>
>         Attachments: HBASE-13755-v1.patch, HBASE-13755-v2.patch, 
> HBASE-13755-v3.patch, HBASE-13755-v3.patch, HBASE-13755-v3.patch, 
> HBASE-13755-v3.patch, HBASE-13755-v3.patch
>
>
> Followup for HBASE-13375.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to