[
https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126051#comment-13126051
]
stack commented on HBASE-1744:
------------------------------
Fancy, you have democlient for thrift2 too!
Thanks for including a package.html. Should be more forceful about thrift one
being deprecated but I can fix on commit.
It doesn't look like much overlap between thrift2 utilities and the other
thrift utilities if any. Thats good.
There are a bunch of spelling mistakes in the patch. I can fix on commit (And
I though you were in skuhl Tim!) -- "Size of pool configuraple"
Bob and Tim, you fellas +1 on committing this latest patch. Do tests pass?
The new thrift2 tests? LarsF you have an opinion?
It looks good to me. If you fellas are good, will commit over next few days.
> Thrift server to match the new java api.
> ----------------------------------------
>
> Key: HBASE-1744
> URL: https://issues.apache.org/jira/browse/HBASE-1744
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: Tim Sell
> Assignee: Tim Sell
> Priority: Critical
> Fix For: 0.94.0
>
> Attachments:
> 0001-thrift2-enable-usage-of-.deleteColumns-for-thrift.patch,
> HBASE-1744.2.patch, HBASE-1744.3.patch, HBASE-1744.4.patch,
> HBASE-1744.5.patch, HBASE-1744.6.patch, HBASE-1744.7.patch,
> HBASE-1744.8.patch, HBASE-1744.9.patch, HBASE-1744.preview.1.patch,
> thriftexperiment.patch
>
>
> This mutateRows, etc.. is a little confusing compared to the new cleaner java
> client.
> Thinking of ways to make a thrift client that is just as elegant. something
> like:
> void put(1:Bytes table, 2:TPut put) throws (1:IOError io)
> with:
> struct TColumn {
> 1:Bytes family,
> 2:Bytes qualifier,
> 3:i64 timestamp
> }
> struct TPut {
> 1:Bytes row,
> 2:map<TColumn, Bytes> values
> }
> This creates more verbose rpc than if the columns in TPut were just
> map<Bytes, map<Bytes, Bytes>>, but that is harder to fit timestamps into and
> still be intuitive from say python.
> Presumably the goal of a thrift gateway is to be easy first.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
