[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141793#comment-13141793 ]
Hadoop QA commented on HBASE-1744: ---------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12501880/1744-trunk.10 against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -165 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 40 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/130//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/130//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/130//console This message is automatically generated. > Thrift server to match the new java api. > ---------------------------------------- > > Key: HBASE-1744 > URL: https://issues.apache.org/jira/browse/HBASE-1744 > Project: HBase > Issue Type: Improvement > Components: thrift > Reporter: Tim Sell > Assignee: Tim Sell > Priority: Critical > Fix For: 0.94.0 > > Attachments: > 0001-thrift2-enable-usage-of-.deleteColumns-for-thrift.patch, 1744-trunk.10, > HBASE-1744.2.patch, HBASE-1744.3.patch, HBASE-1744.4.patch, > HBASE-1744.5.patch, HBASE-1744.6.patch, HBASE-1744.7.patch, > HBASE-1744.8.patch, HBASE-1744.9.patch, HBASE-1744.preview.1.patch, > thriftexperiment.patch > > > This mutateRows, etc.. is a little confusing compared to the new cleaner java > client. > Thinking of ways to make a thrift client that is just as elegant. something > like: > void put(1:Bytes table, 2:TPut put) throws (1:IOError io) > with: > struct TColumn { > 1:Bytes family, > 2:Bytes qualifier, > 3:i64 timestamp > } > struct TPut { > 1:Bytes row, > 2:map<TColumn, Bytes> values > } > This creates more verbose rpc than if the columns in TPut were just > map<Bytes, map<Bytes, Bytes>>, but that is harder to fit timestamps into and > still be intuitive from say python. > Presumably the goal of a thrift gateway is to be easy first. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira