[
https://issues.apache.org/jira/browse/HBASE-13900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14589328#comment-14589328
]
Hadoop QA commented on HBASE-13900:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12740010/HBASE-13900.1.patch
against master branch at commit f469c3bd97d1465534c52dc22934633bdddf189a.
ATTACHMENT ID: 12740010
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14441//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14441//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14441//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14441//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14441//console
This message is automatically generated.
> duplicate methods between ProtobufMagic and ProtobufUtil
> --------------------------------------------------------
>
> Key: HBASE-13900
> URL: https://issues.apache.org/jira/browse/HBASE-13900
> Project: HBase
> Issue Type: Improvement
> Reporter: Gabor Liptak
> Priority: Minor
> Attachments: HBASE-13900.1.patch
>
>
> Several methods duplicated between:
> hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufMagic.java
> and
> hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
> isPBMagicPrefix()
> isPBMagicPrefix()
> lengthOfPBMagic()
> ProtobufUtil partically references ProtobufMagic, but it also has different
> compare implementation ...
> Maybe this was based on packaging/signature need?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
