[
https://issues.apache.org/jira/browse/HBASE-13900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14590737#comment-14590737
]
Gabor Liptak commented on HBASE-13900:
--------------------------------------
I'm not sure what the extra Javadoc warnings was ...
This is a refactoring, existing unit tests are expected to pass.
> duplicate methods between ProtobufMagic and ProtobufUtil
> --------------------------------------------------------
>
> Key: HBASE-13900
> URL: https://issues.apache.org/jira/browse/HBASE-13900
> Project: HBase
> Issue Type: Improvement
> Reporter: Gabor Liptak
> Priority: Minor
> Attachments: HBASE-13900.1.patch
>
>
> Several methods duplicated between:
> hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufMagic.java
> and
> hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
> isPBMagicPrefix()
> isPBMagicPrefix()
> lengthOfPBMagic()
> ProtobufUtil partically references ProtobufMagic, but it also has different
> compare implementation ...
> Maybe this was based on packaging/signature need?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
