[
https://issues.apache.org/jira/browse/HBASE-13893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14590006#comment-14590006
]
stack commented on HBASE-13893:
-------------------------------
In TIFB, a public/stable class, you changed the return from HTable to Table in
below... undo (see below where there is a getTable method that returns Table)...
protected Table getHTable() {
Ditto on the setHTable... you change the param type (Maybe add a setTable in
meantime)?
I think this change can only go into master, and not onto branch-1 to be safe.
In HBaseCommonTestingUtility we are removing a createTable on a Public/Unstable
class without deprecation and we are changing return types. If this is to make
a branch-1, I'd say we need deprecate step and we'd need to provide
alternatives. Doing that would be a massive amount of work (and you have done
mountains already [~jurmous]). You OK then with master branch only?
Man, I think we should do deprecate and alternative methods anyways.... These
classes are popular... Let me get opinion of others (wrote dev list).
In TestFromClientSide, there is this:
if (t instanceof HTable){
and ....
if (t instanceof HTableInterface) {
Later, there'll be a if (t instanceof AsyncTable) ?
I went over the rest of the patch. It is amazing cleanup.
How hard would it be to put back HBaseCommonTestingUtility removals, add
deprecations, and add alternate methods for tests to use instead? If that were
done, and the above TIFB were addressed, I think this great cleanup could go in
branch-1.
> Replace HTable with Table in client tests
> -----------------------------------------
>
> Key: HBASE-13893
> URL: https://issues.apache.org/jira/browse/HBASE-13893
> Project: HBase
> Issue Type: Bug
> Components: Client, test
> Reporter: Jurriaan Mous
> Assignee: Jurriaan Mous
> Attachments: HBASE-13893-v1.patch, HBASE-13893-v2.patch,
> HBASE-13893-v3.patch, HBASE-13893-v3.patch, HBASE-13893-v4.patch,
> HBASE-13893.patch
>
>
> Many client tests reference the HTable implementation instead of the generic
> Table implementation. It is now not possible to reuse the tests for another
> Table implementation. This issue focusses on all HTable instances in relevant
> client tests and thus not all HTable instances.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
