[
https://issues.apache.org/jira/browse/HBASE-13659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591642#comment-14591642
]
Ashish Singhi commented on HBASE-13659:
---------------------------------------
I have attached another patch v1 for branch-1.1. In this instead of starting RS
again at the end of {{testShutdownOfReplicaHolder}} I have set the conf
{{hbase.master.wait.on.regionservers.mintostart}} to 2. With this all the tests
in this class are passing 5/5 times. With the earlier patch for branch-1.1
there were some tests which were flakey
{noformat}
java.lang.AssertionError: null
at
org.apache.hadoop.hbase.client.TestMetaWithReplicas.testMetaAddressChange(TestMetaWithReplicas.java:368)
testHBaseFsckWithMetaReplicas(org.apache.hadoop.hbase.client.TestMetaWithReplicas)
Time elapsed: 0.234 sec <<< FAILURE!
java.lang.AssertionError: expected:<[]> but was:<[MULTI_META_REGION, UNKNOWN]>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:743)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:144)
at
org.apache.hadoop.hbase.util.hbck.HbckTestingUtil.assertNoErrors(HbckTestingUtil.java:91)
at
org.apache.hadoop.hbase.client.TestMetaWithReplicas.testHBaseFsckWithMetaReplicas(TestMetaWithReplicas.java:279)
testHBaseFsckWithExcessMetaReplicas(org.apache.hadoop.hbase.client.TestMetaWithReplicas)
Time elapsed: 1.29 sec <<< FAILURE!
java.lang.AssertionError: expected:<[UNKNOWN, SHOULD_NOT_BE_DEPLOYED]> but
was:<[UNKNOWN, SHOULD_NOT_BE_DEPLOYED, MULTI_META_REGION]>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:743)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:144)
at
org.apache.hadoop.hbase.util.hbck.HbckTestingUtil.assertErrors(HbckTestingUtil.java:99)
at
org.apache.hadoop.hbase.client.TestMetaWithReplicas.testHBaseFsckWithExcessMetaReplicas(TestMetaWithReplicas.java:412)
testHBaseFsckWithFewerMetaReplicas(org.apache.hadoop.hbase.client.TestMetaWithReplicas)
Time elapsed: 1.265 sec <<< FAILURE!
java.lang.AssertionError: expected:<[UNKNOWN, NO_META_REGION]> but
was:<[UNKNOWN, NO_META_REGION, SHOULD_NOT_BE_DEPLOYED, MULTI_META_REGION]>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:743)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:144)
at
org.apache.hadoop.hbase.util.hbck.HbckTestingUtil.assertErrors(HbckTestingUtil.java:99)
at
org.apache.hadoop.hbase.client.TestMetaWithReplicas.testHBaseFsckWithFewerMetaReplicas(TestMetaWithReplicas.java:292)
testMetaLookupThreadPoolCreated(org.apache.hadoop.hbase.client.TestMetaWithReplicas)
Time elapsed: 1.301 sec <<< ERROR!
org.apache.hadoop.hbase.TableNotFoundException: Table
'testMetaLookupThreadPoolCreated' was not found, got: hbase:namespace.
at
org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.locateRegionInMeta(ConnectionManager.java:1274)
at
org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.locateRegion(ConnectionManager.java:1155)
at
org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.relocateRegion(ConnectionManager.java:1126)
at
org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.relocateRegion(ConnectionManager.java:1110)
at
org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.relocateRegion(ConnectionManager.java:1132)
at
org.apache.hadoop.hbase.client.TestMetaWithReplicas.testMetaLookupThreadPoolCreated(TestMetaWithReplicas.java:234)
{noformat}
I could not find out the fix for this as I am not much aware of read replica
feature :(
[~devaraj], [~enis], [~ndimiduk]... can you help on this ?
> Improve test run time for TestMetaWithReplicas class
> ----------------------------------------------------
>
> Key: HBASE-13659
> URL: https://issues.apache.org/jira/browse/HBASE-13659
> Project: HBase
> Issue Type: Sub-task
> Components: test
> Affects Versions: 1.1.0
> Reporter: Ashish Singhi
> Assignee: Ashish Singhi
> Fix For: 2.0.0, 1.2.0, 1.1.2, 1.3.0
>
> Attachments: HBASE-13659-branch-1.1-v1.patch,
> HBASE-13659-branch-1.1.patch, HBASE-13659.patch,
> org.apache.hadoop.hbase.client.TestMetaWithReplicas-output.txt
>
>
> In TestMetaWithReplicas, start and shutdown of mini cluster is done at start
> and end of every test in that class respectively, which makes the test class
> to take more time to complete. Instead we can start and stop the mini cluster
> only once per the class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
