[ 
https://issues.apache.org/jira/browse/HBASE-13659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611282#comment-14611282
 ] 

Nick Dimiduk commented on HBASE-13659:
--------------------------------------

adding

{noformat}
    RegionLocator metaLoc = 
TEST_UTIL.getConnection().getRegionLocator(TableName.META_TABLE_NAME);
    LOG.info("testMetaAddressChange -- metaLocator says "
            + metaLoc.getRegionLocation(null).getServerName().getServerName());
{noformat}

It now seems the way the test parses meta location and the location returned by 
{{RegionLocator}} instance disagree. Maybe {{RegionLocator}} is not looking 
specifically for the first replica?

{noformat}
2015-07-01 17:57:53,135 INFO  [main] client.TestMetaWithReplicas(340): 
testMetaAddressChange -- starting test.
2015-07-01 17:57:53,136 INFO  [main] client.TestMetaWithReplicas(350): 
testMetaAddressChange -- parsed meta location is 10.0.0.110,59702,1435798645712
2015-07-01 17:57:53,136 INFO  [main] client.TestMetaWithReplicas(352): 
testMetaAddressChange -- metaLocator says 10.0.0.110,59570,1435798598482
{noformat}

Test looks for meta with

{noformat}
    ZooKeeperWatcher zkw = TEST_UTIL.getZooKeeperWatcher();
    String baseZNode = conf.get(HConstants.ZOOKEEPER_ZNODE_PARENT,
        HConstants.DEFAULT_ZOOKEEPER_ZNODE_PARENT);
    String primaryMetaZnode = ZKUtil.joinZNode(baseZNode,
        conf.get("zookeeper.znode.metaserver", "meta-region-server"));
{noformat}

while {{ZooKeeperWatcher}} appears to use

{noformat}
      str = ZKUtil.joinZNode(baseZNode,
          conf.get("zookeeper.znode.metaserver", "meta-region-server") + "-" + 
replicaId);
{noformat}

Looking at logic in {{MetaTableLocator}}, it seems to specify a default 
replicaId of 1, which means it'll always be going to a {{"-" + replicaId}} 
location instead of the bare location used in the test.

> Improve test run time for TestMetaWithReplicas class
> ----------------------------------------------------
>
>                 Key: HBASE-13659
>                 URL: https://issues.apache.org/jira/browse/HBASE-13659
>             Project: HBase
>          Issue Type: Sub-task
>          Components: test
>    Affects Versions: 1.1.0
>            Reporter: Ashish Singhi
>            Assignee: Ashish Singhi
>             Fix For: 2.0.0, 1.2.0, 1.1.2, 1.3.0
>
>         Attachments: HBASE-13659-branch-1.1-v1.patch, 
> HBASE-13659-branch-1.1.patch, HBASE-13659.patch, 
> org.apache.hadoop.hbase.client.TestMetaWithReplicas-output.txt
>
>
> In TestMetaWithReplicas, start and shutdown of mini cluster is done at start 
> and end of every test in that class respectively, which makes the test class 
> to take more time to complete. Instead we can start and stop the mini cluster 
> only once per the class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to