[
https://issues.apache.org/jira/browse/HBASE-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126339#comment-13126339
]
Lars Hofhansl commented on HBASE-4556:
--------------------------------------
It turns out most of the test are written in a way the either just counts the
rows (where while(s.next(...)) is OK, or rely on the fact that kvs is never
empty.
Rather than messing with the tests, I am just going to fix the two obvious
issues in the production code (HMerge and Store).
> Fix all incorrect uses of InternalScanner.next(...)
> ---------------------------------------------------
>
> Key: HBASE-4556
> URL: https://issues.apache.org/jira/browse/HBASE-4556
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Attachments: 4556.txt
>
>
> There are cases all over the code where InternalScanner.next(...) is not used
> correctly.
> I see this a lot:
> {code}
> while(scanner.next(...)) {
> }
> {code}
> The correct pattern is:
> {code}
> boolean more = false;
> do {
> more = scanner.next(...);
> } while (more);
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
