[
https://issues.apache.org/jira/browse/HBASE-12295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597409#comment-14597409
]
Hadoop QA commented on HBASE-12295:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12741247/HBASE-12295_9.patch
against master branch at commit 6a537eb8545c7dd6c01c0d911ad12e789eeab3ae.
ATTACHMENT ID: 12741247
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 45 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
1919 checkstyle errors (more than the master's current 1906 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ * read data from such cache, we will make a cell referring to the same
memory and will avoid any copy.
+ if (blockCache != null && block != null && block.getMemoryType() !=
MemoryType.NON_SHARED_MEMORY) {
+ ret = new SharedMemorySizeCachedNoTagsKeyValue(blockBuffer.array(),
blockBuffer.arrayOffset()
+ // those cells are referring to a shared memory area which if evicted by
the BucketCache would lead
+ // readers using this block are aware of this fact and do the necessary
action to prevent eviction
+ public Result internalGet(Get get, boolean withCoprocessor,
ListRegionScannerCloseCallBack closeCallBack,
+ // An RpcCallBack that creates a list of scanners that needs to perform
callBack operation on completion of multiGets
+ // HBaseAdmin only waits for regions to appear in hbase:meta we should
wait until they are assigned
+ public void testGetsWithMultiColumnsAndExplicitTracker() throws IOException,
InterruptedException {
+ private void slowdownCode(final
ObserverContext<RegionCoprocessorEnvironment> e, boolean isGet) {
{color:red}-1 site{color}. The patch appears to cause mvn post-site goal
to fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14527//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14527//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14527//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14527//console
This message is automatically generated.
> Prevent block eviction under us if reads are in progress from the BBs
> ---------------------------------------------------------------------
>
> Key: HBASE-12295
> URL: https://issues.apache.org/jira/browse/HBASE-12295
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver, Scanners
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 2.0.0
>
> Attachments: HBASE-12295.pdf, HBASE-12295_1.patch, HBASE-12295_1.pdf,
> HBASE-12295_2.patch, HBASE-12295_4.patch, HBASE-12295_4.pdf,
> HBASE-12295_5.pdf, HBASE-12295_9.patch, HBASE-12295_trunk.patch
>
>
> While we try to serve the reads from the BBs directly from the block cache,
> we need to ensure that the blocks does not get evicted under us while
> reading. This JIRA is to discuss and implement a strategy for the same.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
