[
https://issues.apache.org/jira/browse/HBASE-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599015#comment-14599015
]
Hadoop QA commented on HBASE-13939:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12741457/HBASE-13939_3.patch
against master branch at commit b7f241d73b79ec22db2c03cb6b384b76185f0f85.
ATTACHMENT ID: 12741457
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:red}-1 javac{color}. The patch appears to cause mvn compile goal to
fail with Hadoop version 2.3.0.
Compilation errors resume:
[ERROR] COMPILATION ERROR :
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java:[75,30]
cannot find symbol
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java:[2064,17]
cannot find symbol
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java:[42,30]
cannot find symbol
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java:[92,11]
cannot find symbol
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java:[2086,15]
cannot find symbol
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.2:compile (default-compile) on
project hbase-server: Compilation failure: Compilation failure:
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java:[75,30]
cannot find symbol
[ERROR] symbol: class DFSHedgedReadMetrics
[ERROR] location: package org.apache.hadoop.hdfs
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java:[2064,17]
cannot find symbol
[ERROR] symbol: class DFSHedgedReadMetrics
[ERROR] location: class org.apache.hadoop.hbase.util.FSUtils
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java:[42,30]
cannot find symbol
[ERROR] symbol: class DFSHedgedReadMetrics
[ERROR] location: package org.apache.hadoop.hdfs
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java:[92,11]
cannot find symbol
[ERROR] symbol: class DFSHedgedReadMetrics
[ERROR] location: class
org.apache.hadoop.hbase.regionserver.MetricsRegionServerWrapperImpl
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java:[2086,15]
cannot find symbol
[ERROR] symbol: class DFSHedgedReadMetrics
[ERROR] location: class org.apache.hadoop.hbase.util.FSUtils
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <goals> -rf :hbase-server
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14539//console
This message is automatically generated.
> Make HFileReaderImpl.getFirstKeyInBlock() to return a Cell
> ----------------------------------------------------------
>
> Key: HBASE-13939
> URL: https://issues.apache.org/jira/browse/HBASE-13939
> Project: HBase
> Issue Type: Sub-task
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Minor
> Fix For: 2.0.0, 1.1.2
>
> Attachments: HBASE-13939.patch, HBASE-13939_1.patch,
> HBASE-13939_2.patch, HBASE-13939_3.patch, HBASE-13939_branch-1.1.patch
>
>
> The getFirstKeyInBlock() in HFileReaderImpl is returning a BB. It is getting
> used in seekBefore cases. Because we return a BB we create a KeyOnlyKV once
> for comparison
> {code}
> if (reader.getComparator()
> .compareKeyIgnoresMvcc(
> new KeyValue.KeyOnlyKeyValue(firstKey.array(),
> firstKey.arrayOffset(),
> firstKey.limit()), key) >= 0) {
> long previousBlockOffset = seekToBlock.getPrevBlockOffset();
> // The key we are interested in
> if (previousBlockOffset == -1) {
> // we have a 'problem', the key we want is the first of the file.
> return false;
> }
> ........
> {code}
> And if the compare fails we again create another KeyOnlyKv
> {code}
> Cell firstKeyInCurrentBlock = new
> KeyValue.KeyOnlyKeyValue(Bytes.getBytes(firstKey));
> loadBlockAndSeekToKey(seekToBlock, firstKeyInCurrentBlock, true, key,
> true);
> {code}
> So one object will be enough and that can be returned by getFirstKeyInBlock.
> Also will be useful when we go with Buffered backed server cell to change in
> one place.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
