[
https://issues.apache.org/jira/browse/HBASE-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602408#comment-14602408
]
stack commented on HBASE-13939:
-------------------------------
Failures are:
kalashnikov:hbase.git stack$ python ./dev-support/findHangingTests.py
https://builds.apache.org/job/PreCommit-HBASE-Build/14548/consoleText
Fetching the console output from the URL
Printing hanging tests
Printing Failing tests
Failing test : org.apache.hadoop.hbase.client.TestFastFail
Failing test : org.apache.hadoop.hbase.master.TestDistributedLogSplitting
Look unrelated and common failures currently.
Looked at patch again. Nice. +1 to commit [~ram_krish]
> Make HFileReaderImpl.getFirstKeyInBlock() to return a Cell
> ----------------------------------------------------------
>
> Key: HBASE-13939
> URL: https://issues.apache.org/jira/browse/HBASE-13939
> Project: HBase
> Issue Type: Sub-task
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Minor
> Fix For: 2.0.0, 1.1.2
>
> Attachments: HBASE-13939.patch, HBASE-13939_1.patch,
> HBASE-13939_2.patch, HBASE-13939_3.patch, HBASE-13939_3.patch,
> HBASE-13939_branch-1.1.patch
>
>
> The getFirstKeyInBlock() in HFileReaderImpl is returning a BB. It is getting
> used in seekBefore cases. Because we return a BB we create a KeyOnlyKV once
> for comparison
> {code}
> if (reader.getComparator()
> .compareKeyIgnoresMvcc(
> new KeyValue.KeyOnlyKeyValue(firstKey.array(),
> firstKey.arrayOffset(),
> firstKey.limit()), key) >= 0) {
> long previousBlockOffset = seekToBlock.getPrevBlockOffset();
> // The key we are interested in
> if (previousBlockOffset == -1) {
> // we have a 'problem', the key we want is the first of the file.
> return false;
> }
> ........
> {code}
> And if the compare fails we again create another KeyOnlyKv
> {code}
> Cell firstKeyInCurrentBlock = new
> KeyValue.KeyOnlyKeyValue(Bytes.getBytes(firstKey));
> loadBlockAndSeekToKey(seekToBlock, firstKeyInCurrentBlock, true, key,
> true);
> {code}
> So one object will be enough and that can be returned by getFirstKeyInBlock.
> Also will be useful when we go with Buffered backed server cell to change in
> one place.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
