[ 
https://issues.apache.org/jira/browse/HBASE-13980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608260#comment-14608260
 ] 

Ted Yu commented on HBASE-13980:
--------------------------------

{code}
223               tunerLog += "Increasing memstore size as observed blocked 
flushes."
{code}
Please include the blockedFlushCount

> Distinguish blockedFlushCount vs unblockedFlushCount when tuning heap memory
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-13980
>                 URL: https://issues.apache.org/jira/browse/HBASE-13980
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Abhilash
>            Priority: Minor
>         Attachments: HBASE-13980.patch
>
>
> Currently DefaultHeapMemoryTuner doesn't distinguish blockedFlushCount vs 
> unblockedFlushCount.
> In its tune() method:
> {code}
>     long totalFlushCount = blockedFlushCount+unblockedFlushCount;
>     rollingStatsForCacheMisses.insertDataValue(cacheMissCount);
>     rollingStatsForFlushes.insertDataValue(totalFlushCount);
> {code}
> Occurrence of blocked flush indicates that upper limit for memstore is not 
> sufficient.
> We should either give blockedFlushCount more weight or, take tuning action 
> based on blockedFlushCount directly.
> See discussion from tail of HBASE-13876.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to