[
https://issues.apache.org/jira/browse/HBASE-13980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609441#comment-14609441
]
Hadoop QA commented on HBASE-13980:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12742970/HBASE-13980-v1.patch
against master branch at commit 42d5ef017d3d629e6ca9ee93e15ac4f0f9e00ce1.
ATTACHMENT ID: 12742970
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.wal.TestWALFiltering
org.apache.hadoop.hbase.replication.TestPerTableCFReplication
org.apache.hadoop.hbase.coprocessor.TestRegionObserverInterface
org.apache.hadoop.hbase.coprocessor.TestDoubleColumnInterpreter
org.apache.hadoop.hbase.regionserver.TestHRegionServerBulkLoad
org.apache.hadoop.hbase.TestFullLogReconstruction
org.apache.hadoop.hbase.procedure.TestZKProcedure
org.apache.hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster
org.apache.hadoop.hbase.security.access.TestAccessController
org.apache.hadoop.hbase.coprocessor.TestCoprocessorTableEndpoint
org.apache.hadoop.hbase.regionserver.TestSCVFWithMiniCluster
org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite
org.apache.hadoop.hbase.coprocessor.TestHTableWrapper
org.apache.hadoop.hbase.util.TestMergeTool
org.apache.hadoop.hbase.TestIOFencing
org.apache.hadoop.hbase.fs.TestBlockReorder
org.apache.hadoop.hbase.wal.TestDefaultWALProviderWithHLogKey
org.apache.hadoop.hbase.TestHBaseTestingUtility
org.apache.hadoop.hbase.regionserver.TestClusterId
org.apache.hadoop.hbase.security.visibility.TestVisibilityLablesWithGroups
org.apache.hadoop.hbase.regionserver.wal.TestLogRollAbort
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsOpWithDifferentUsersNoACL
org.apache.hadoop.hbase.io.encoding.TestChangingEncoding
org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient
org.apache.hadoop.hbase.replication.TestReplicationTrackerZKImpl
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort
org.apache.hadoop.hbase.coprocessor.TestBigDecimalColumnInterpreter
org.apache.hadoop.hbase.security.visibility.TestWithDisabledAuthorization
org.apache.hadoop.hbase.regionserver.TestRegionServerOnlineConfigChange
org.apache.hadoop.hbase.regionserver.TestParallelPut
org.apache.hadoop.hbase.regionserver.TestRSKilledWhenInitializing
org.apache.hadoop.hbase.regionserver.TestSplitWalDataLoss
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithRemove
org.apache.hadoop.hbase.filter.TestFilterWithScanLimits
org.apache.hadoop.hbase.regionserver.TestDefaultMemStore
org.apache.hadoop.hbase.regionserver.TestHRegionOnCluster
org.apache.hadoop.hbase.quotas.TestQuotaThrottle
org.apache.hadoop.hbase.util.TestMiniClusterLoadEncoded
org.apache.hadoop.hbase.regionserver.TestJoinedScanners
org.apache.hadoop.hbase.regionserver.TestCompoundBloomFilter
org.apache.hadoop.hbase.security.access.TestScanEarlyTermination
org.apache.hadoop.hbase.regionserver.compactions.TestCompactionWithThroughputController
org.apache.hadoop.hbase.util.TestMiniClusterLoadParallel
org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint
org.apache.hadoop.hbase.security.visibility.TestEnforcingScanLabelGenerator
org.apache.hadoop.hbase.regionserver.wal.TestLogRollPeriod
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDistributedLogReplay
org.apache.hadoop.hbase.util.TestMiniClusterLoadSequential
org.apache.hadoop.hbase.filter.TestFuzzyRowAndColumnRangeFilter
org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
org.apache.hadoop.hbase.filter.TestFilterWrapper
org.apache.hadoop.hbase.io.encoding.TestEncodedSeekers
org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpointNoMaster
org.apache.hadoop.hbase.TestGlobalMemStoreSize
org.apache.hadoop.hbase.TestMultiVersions
org.apache.hadoop.hbase.regionserver.wal.TestLogRolling
org.apache.hadoop.hbase.regionserver.wal.TestFSHLog
org.apache.hadoop.hbase.regionserver.TestRegionReplicas
org.apache.hadoop.hbase.zookeeper.TestZKLeaderManager
org.apache.hadoop.hbase.TestMovedRegionsCleaner
org.apache.hadoop.hbase.wal.TestWALSplitCompressed
org.apache.hadoop.hbase.replication.TestReplicationKillSlaveRS
org.apache.hadoop.hbase.util.TestHBaseFsck
org.apache.hadoop.hbase.regionserver.TestPerColumnFamilyFlush
org.apache.hadoop.hbase.TestNamespace
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorEndpoint
org.apache.hadoop.hbase.replication.TestReplicationSmallTests
org.apache.hadoop.hbase.snapshot.TestSnapshotClientRetries
org.apache.hadoop.hbase.replication.TestReplicationKillMasterRSCompressed
org.apache.hadoop.hbase.io.hfile.TestHFileBlockIndex
org.apache.hadoop.hbase.regionserver.TestTags
org.apache.hadoop.hbase.util.TestMergeTable
org.apache.hadoop.hbase.filter.TestScanRowPrefix
org.apache.hadoop.hbase.wal.TestSecureWAL
org.apache.hadoop.hbase.regionserver.TestCacheOnWriteInSchema
org.apache.hadoop.hbase.zookeeper.TestRecoverableZooKeeper
org.apache.hadoop.hbase.replication.TestMasterReplication
org.apache.hadoop.hbase.wal.TestBoundedRegionGroupingProvider
org.apache.hadoop.hbase.mapred.TestTableMapReduceUtil
org.apache.hadoop.hbase.coprocessor.TestRowProcessorEndpoint
org.apache.hadoop.hbase.security.visibility.TestDefaultScanLabelGeneratorStack
org.apache.hadoop.hbase.regionserver.TestRegionFavoredNodes
org.apache.hadoop.hbase.snapshot.TestExportSnapshot
org.apache.hadoop.hbase.security.token.TestGenerateDelegationToken
org.apache.hadoop.hbase.constraint.TestConstraint
org.apache.hadoop.hbase.coprocessor.TestBatchCoprocessorEndpoint
org.apache.hadoop.hbase.coprocessor.TestMasterCoprocessorExceptionWithAbort
org.apache.hadoop.hbase.coprocessor.TestRegionServerObserver
org.apache.hadoop.hbase.quotas.TestQuotaAdmin
org.apache.hadoop.hbase.procedure.TestZKProcedureControllers
org.apache.hadoop.hbase.mapreduce.TestHashTable
org.apache.hadoop.hbase.ipc.TestDelayedRpc
org.apache.hadoop.hbase.wal.TestWALSplit
org.apache.hadoop.hbase.security.visibility.TestVisibilityWithCheckAuths
org.apache.hadoop.hbase.regionserver.TestRegionServerNoMaster
org.apache.hadoop.hbase.regionserver.wal.TestWALReplayCompressed
org.apache.hadoop.hbase.regionserver.TestGetClosestAtOrBefore
org.apache.hadoop.hbase.TestPartialResultsFromClientSide
org.apache.hadoop.hbase.coprocessor.TestRegionObserverScannerOpenHook
org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient
org.apache.hadoop.hbase.quotas.TestQuotaTableUtil
org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover
org.apache.hadoop.hbase.util.TestConnectionCache
org.apache.hadoop.hbase.TestZooKeeper
org.apache.hadoop.hbase.regionserver.TestRecoveredEdits
org.apache.hadoop.hbase.mapred.TestMultiTableSnapshotInputFormat
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelReplicationWithExpAsString
org.apache.hadoop.hbase.util.TestCoprocessorScanPolicy
org.apache.hadoop.hbase.regionserver.wal.TestSecureWALReplay
org.apache.hadoop.hbase.regionserver.TestHRegionReplayEvents
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithCustomVisLabService
org.apache.hadoop.hbase.TestRegionRebalancing
org.apache.hadoop.hbase.replication.TestReplicationWithTags
org.apache.hadoop.hbase.TestAcidGuarantees
org.apache.hadoop.hbase.coprocessor.TestClassLoading
org.apache.hadoop.hbase.regionserver.TestCompactionState
org.apache.hadoop.hbase.coprocessor.TestWALObserver
org.apache.hadoop.hbase.regionserver.TestCompactionWithCoprocessor
org.apache.hadoop.hbase.regionserver.TestBlocksRead
org.apache.hadoop.hbase.TestMetaTableLocator
org.apache.hadoop.hbase.security.access.TestAccessControlFilter
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsReplication
org.apache.hadoop.hbase.util.TestRegionSplitter
org.apache.hadoop.hbase.TestInfoServers
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes
org.apache.hadoop.hbase.security.access.TestTablePermissions
org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildOverlap
org.apache.hadoop.hbase.replication.TestMultiSlaveReplication
org.apache.hadoop.hbase.regionserver.wal.TestDurability
org.apache.hadoop.hbase.TestMetaTableAccessor
org.apache.hadoop.hbase.mapred.TestTableSnapshotInputFormat
org.apache.hadoop.hbase.security.access.TestAccessController2
org.apache.hadoop.hbase.regionserver.wal.TestProtobufLog
org.apache.hadoop.hbase.TestHColumnDescriptorDefaultVersions
org.apache.hadoop.hbase.regionserver.TestScannerHeartbeatMessages
org.apache.hadoop.hbase.coprocessor.TestAggregateProtocol
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL
org.apache.hadoop.hbase.TestMetaTableAccessorNoCluster
org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildBase
org.apache.hadoop.hbase.trace.TestHTraceHooks
org.apache.hadoop.hbase.regionserver.TestMasterAddressTracker
org.apache.hadoop.hbase.replication.TestReplicationStateZKImpl
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithSLGStack
org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide
org.apache.hadoop.hbase.regionserver.wal.TestWALReplay
org.apache.hadoop.hbase.regionserver.TestMinorCompaction
org.apache.hadoop.hbase.coprocessor.TestOpenTableInCoprocessor
org.apache.hadoop.hbase.security.access.TestWithDisabledAuthorization
org.apache.hadoop.hbase.replication.TestReplicationKillMasterRS
org.apache.hadoop.hbase.coprocessor.TestMasterObserver
org.apache.hadoop.hbase.security.access.TestCellACLWithMultipleVersions
org.apache.hadoop.hbase.regionserver.TestRowTooBig
org.apache.hadoop.hbase.security.token.TestZKSecretWatcher
org.apache.hadoop.hbase.regionserver.TestRegionServerHostname
org.apache.hadoop.hbase.io.hfile.TestScannerSelectionUsingTTL
org.apache.hadoop.hbase.regionserver.TestCompaction
org.apache.hadoop.hbase.wal.TestWALReaderOnSecureWAL
org.apache.hadoop.hbase.regionserver.TestMultiColumnScanner
org.apache.hadoop.hbase.regionserver.TestRegionServerMetrics
org.apache.hadoop.hbase.regionserver.TestAtomicOperation
org.apache.hadoop.hbase.zookeeper.TestZKMulti
org.apache.hadoop.hbase.coprocessor.TestRegionObserverBypass
org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint
org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk
org.apache.hadoop.hbase.io.hfile.TestHFileSeek
org.apache.hadoop.hbase.wal.TestDefaultWALProvider
org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster
org.apache.hadoop.hbase.replication.TestReplicationDisableInactivePeer
org.apache.hadoop.hbase.regionserver.TestSplitLogWorker
org.apache.hadoop.hbase.zookeeper.lock.TestZKInterProcessReadWriteLock
org.apache.hadoop.hbase.regionserver.TestReversibleScanners
org.apache.hadoop.hbase.regionserver.TestServerCustomProtocol
org.apache.hadoop.hbase.replication.regionserver.TestReplicationSourceManager
org.apache.hadoop.hbase.regionserver.TestPriorityRpc
org.apache.hadoop.hbase.regionserver.TestHRegion
org.apache.hadoop.hbase.TestLocalHBaseCluster
org.apache.hadoop.hbase.regionserver.TestScannerWithBulkload
org.apache.hadoop.hbase.backup.TestHFileArchiving
org.apache.hadoop.hbase.coprocessor.TestMasterCoprocessorExceptionWithRemove
org.apache.hadoop.hbase.mapred.TestTableInputFormat
org.apache.hadoop.hbase.TestJMXListener
org.apache.hadoop.hbase.replication.TestReplicationSyncUpTool
org.apache.hadoop.hbase.replication.regionserver.TestReplicationSink
org.apache.hadoop.hbase.regionserver.TestEncryptionKeyRotation
org.apache.hadoop.hbase.security.access.TestZKPermissionsWatcher
org.apache.hadoop.hbase.regionserver.TestSeekOptimizations
org.apache.hadoop.hbase.replication.TestReplicationEndpoint
org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildHole
org.apache.hadoop.hbase.replication.TestReplicationChangingPeerRegionservers
org.apache.hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd
org.apache.hadoop.hbase.replication.regionserver.TestReplicationWALReaderManager
org.apache.hadoop.hbase.regionserver.TestMajorCompaction
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.wal.TestWALFactory
org.apache.hadoop.hbase.filter.TestColumnRangeFilter
org.apache.hadoop.hbase.coprocessor.TestCoprocessorStop
org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot
org.apache.hadoop.hbase.regionserver.TestFSErrorsExposed
org.apache.hadoop.hbase.security.access.TestNamespaceCommands
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDefaultVisLabelService
org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks
org.apache.hadoop.hbase.regionserver.TestRegionServerReportForDuty
org.apache.hadoop.hbase.security.access.TestCellACLs
org.apache.hadoop.hbase.regionserver.TestScannerRetriableFailure
org.apache.hadoop.hbase.regionserver.TestCorruptedRegionStoreFile
org.apache.hadoop.hbase.regionserver.TestStore
org.apache.hadoop.hbase.util.TestHBaseFsckEncryption
org.apache.hadoop.hbase.filter.TestMultiRowRangeFilter
org.apache.hadoop.hbase.regionserver.TestEncryptionRandomKeying
org.apache.hadoop.hbase.zookeeper.TestZooKeeperNodeTracker
org.apache.hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient
{color:red}-1 core zombie tests{color}. There are 7 zombie test(s):
at
org.apache.hadoop.hbase.ipc.TestProtoBufRpc.testProtoBufRpc(TestProtoBufRpc.java:125)
at
org.apache.phoenix.mapreduce.IndexToolIT.testSecondaryIndex(IndexToolIT.java:131)
at
org.apache.phoenix.mapreduce.IndexToolIT.testMutableGlobalIndex(IndexToolIT.java:84)
at
org.apache.phoenix.end2end.AlterTableIT.testDivorcedViewsStayDivorced(AlterTableIT.java:2210)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14632//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14632//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14632//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14632//console
This message is automatically generated.
> Distinguish blockedFlushCount vs unblockedFlushCount when tuning heap memory
> ----------------------------------------------------------------------------
>
> Key: HBASE-13980
> URL: https://issues.apache.org/jira/browse/HBASE-13980
> Project: HBase
> Issue Type: Improvement
> Reporter: Ted Yu
> Assignee: Abhilash
> Priority: Minor
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-13980-v1.patch, HBASE-13980.patch,
> HBASE-13980.patch
>
>
> Currently DefaultHeapMemoryTuner doesn't distinguish blockedFlushCount vs
> unblockedFlushCount.
> In its tune() method:
> {code}
> long totalFlushCount = blockedFlushCount+unblockedFlushCount;
> rollingStatsForCacheMisses.insertDataValue(cacheMissCount);
> rollingStatsForFlushes.insertDataValue(totalFlushCount);
> {code}
> Occurrence of blocked flush indicates that upper limit for memstore is not
> sufficient.
> We should either give blockedFlushCount more weight or, take tuning action
> based on blockedFlushCount directly.
> See discussion from tail of HBASE-13876.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
