[ 
https://issues.apache.org/jira/browse/HBASE-13977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608682#comment-14608682
 ] 

ramkrishna.s.vasudevan commented on HBASE-13977:
------------------------------------------------

bq.Do we need to change it now? If we miss below kind of checks in some places 
we will land in issues
You mean change the above illegal argument exception? In places where the 
getValue APIs are used.  I remember that explicitly this was asked to be done 
in case they use the KeyOnlyKV in actual code path.  These changes are only in 
helper methods like toString and should be fine I think.
bq.Cell getLastKey -> to be named as getLastKeyAsCell?
The getFirstKey and getMidkey have not been changed. So it is ok to continue 
the same name I would say.
bq.Instead of cloneRow can pass lastKV.getRowArray, offset and length and make 
KV?
This we can do. But I thought its better we do it after we create those Fake 
keys that we created for 11425?

> Convert getKey and related APIs to Cell
> ---------------------------------------
>
>                 Key: HBASE-13977
>                 URL: https://issues.apache.org/jira/browse/HBASE-13977
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: HBASE-13977.patch, HBASE-13977_1.patch, 
> HBASE-13977_2.patch
>
>
> During the course of changes for HBASE-11425 felt that more APIs can be 
> converted to return Cell instead of BB like getKey, getLastKey. 
> We can also rename the getKeyValue to getCell.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to