[
https://issues.apache.org/jira/browse/HBASE-13977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609640#comment-14609640
]
ramkrishna.s.vasudevan commented on HBASE-13977:
------------------------------------------------
bq.Directly make the Cell out of current.keyBuffer? Do we need to clone that
(if so also byte[] copy and create KV)?
I think it is better we copy it. Now we are using this API mainly in two
places getFirstKey and getLastKey. The getFirstKey is getting used as an
instance in HalfStorefileReader (firstKey). So better to copy and use it and
also it is one time operation.
bq.Instead of cloneRow can pass lastKV.getRowArray, offset and length and make
KV?
I updated and changed the patch according to the comment. Here it makes sense
because we are forming the lastKV and firstKV from the getLastKey and
getFirstKey API. The getLastKey and getFirstKey has done a copy and so there is
no need to do another clone and again make the KV constructor to do a copy.
The IllegalArgException I have not changed in this patch.
> Convert getKey and related APIs to Cell
> ---------------------------------------
>
> Key: HBASE-13977
> URL: https://issues.apache.org/jira/browse/HBASE-13977
> Project: HBase
> Issue Type: Improvement
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Attachments: HBASE-13977.patch, HBASE-13977_1.patch,
> HBASE-13977_2.patch, HBASE-13977_3.patch
>
>
> During the course of changes for HBASE-11425 felt that more APIs can be
> converted to return Cell instead of BB like getKey, getLastKey.
> We can also rename the getKeyValue to getCell.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
