[
https://issues.apache.org/jira/browse/HBASE-13981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611407#comment-14611407
]
Apekshit Sharma commented on HBASE-13981:
-----------------------------------------
Thanks for doing additional changes style changes.
just 2 minor things.
extra quote sign after =|
{code}
" -D" + SEPARATOR_CONF_KEY + "=|' - eg separate on pipes instead of tabs\n" +
{code}
mis-alignment here and in other similar places. Should be aligned with previous
line.
{code}
"The column names of the TSV data must be specified using the -D" +
COLUMNS_CONF_KEY + " option. This option takes the form of " +
{code}
> Fix ImportTsv spelling and usage issues
> ---------------------------------------
>
> Key: HBASE-13981
> URL: https://issues.apache.org/jira/browse/HBASE-13981
> Project: HBase
> Issue Type: Bug
> Components: mapreduce
> Affects Versions: 1.1.0.1
> Reporter: Lars George
> Assignee: Gabor Liptak
> Labels: beginner
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-13981.1.patch, HBASE-13981.2.patch
>
>
> The {{ImportTsv}} tool has various spelling and formatting issues. Fix those.
> In code:
> {noformat}
> public final static String ATTRIBUTE_SEPERATOR_CONF_KEY =
> "attributes.seperator";
> {noformat}
> It is "separator".
> In usage text:
> {noformat}
> "input data. Another special columnHBASE_TS_KEY designates that this column
> should be"
> {noformat}
> Space missing.
> {noformat}
> "Record with invalid timestamps (blank, non-numeric) will be treated as bad
> record."
> {noformat}
> "Records ... as bad records" - plural missing twice.
> {noformat}
> "HBASE_ATTRIBUTES_KEY can be used to specify Operation Attributes per record.
> Should be specified as key=>value where -1 is used
> as the seperator. Note that more than one OperationAttributes can be
> specified."
> {noformat}
> - Remove line wraps and indentation.
> - Fix "separator".
> - Fix wrong separator being output, it is not "-1" (wrong constant use in
> code)
> - General wording/style could be better (eg. last sentence now uses
> OperationAttributes without a space).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
