[
https://issues.apache.org/jira/browse/HBASE-13981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632505#comment-14632505
]
Hadoop QA commented on HBASE-13981:
-----------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12745366/HBASE-13981.4.patch
against master branch at commit 338e39970ba8e4835733669b9252d073b2157b8a.
ATTACHMENT ID: 12745366
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 7 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14823//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14823//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14823//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14823//console
This message is automatically generated.
> Fix ImportTsv spelling and usage issues
> ---------------------------------------
>
> Key: HBASE-13981
> URL: https://issues.apache.org/jira/browse/HBASE-13981
> Project: HBase
> Issue Type: Bug
> Components: mapreduce
> Affects Versions: 1.1.0.1
> Reporter: Lars George
> Assignee: Gabor Liptak
> Labels: beginner
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-13981.1.patch, HBASE-13981.2.patch,
> HBASE-13981.3.patch, HBASE-13981.4.patch
>
>
> The {{ImportTsv}} tool has various spelling and formatting issues. Fix those.
> In code:
> {noformat}
> public final static String ATTRIBUTE_SEPERATOR_CONF_KEY =
> "attributes.seperator";
> {noformat}
> It is "separator".
> In usage text:
> {noformat}
> "input data. Another special columnHBASE_TS_KEY designates that this column
> should be"
> {noformat}
> Space missing.
> {noformat}
> "Record with invalid timestamps (blank, non-numeric) will be treated as bad
> record."
> {noformat}
> "Records ... as bad records" - plural missing twice.
> {noformat}
> "HBASE_ATTRIBUTES_KEY can be used to specify Operation Attributes per record.
> Should be specified as key=>value where -1 is used
> as the seperator. Note that more than one OperationAttributes can be
> specified."
> {noformat}
> - Remove line wraps and indentation.
> - Fix "separator".
> - Fix wrong separator being output, it is not "-1" (wrong constant use in
> code)
> - General wording/style could be better (eg. last sentence now uses
> OperationAttributes without a space).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
