[
https://issues.apache.org/jira/browse/HBASE-12213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611862#comment-14611862
]
Anoop Sam John commented on HBASE-12213:
----------------------------------------
Gone through the patch quickly once. Some immediate comments
ByteBufferUtils -> already added getLong/getInt etc methods.. Named them as
toInt/toLong to be consistent with Bytes.java.. So avoid.. Also looks like
some methods moved from one place to another.. All these unwanted changes pls
avoid.
UnsafeAccess -> Here also methods are there to read int/long etc and making
use of that in BBUtils. Also in compare(BB,BB) also making use of this Unsafe
based way.. Pls avoid the compare kind of logic from this class.
Will do more closer look at other area.. Thanks
> HFileBlock backed by Array of ByteBuffers
> -----------------------------------------
>
> Key: HBASE-12213
> URL: https://issues.apache.org/jira/browse/HBASE-12213
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver, Scanners
> Reporter: Anoop Sam John
> Assignee: ramkrishna.s.vasudevan
> Attachments: HBASE-12213_1.patch
>
>
> In L2 cache (offheap) an HFile block might have been cached into multiple
> chunks of buffers. If HFileBlock need single BB, we will end up in recreation
> of bigger BB and copying. Instead we can make HFileBlock to serve data from
> an array of BBs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
