[ https://issues.apache.org/jira/browse/HBASE-12213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14613620#comment-14613620 ]
Hadoop QA commented on HBASE-12213: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12743465/HBASE-12213_2.patch against master branch at commit e640f1e76af8f32015f475629610da127897f01e. ATTACHMENT ID: 12743465 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 47 new or modified tests. {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0) {color:red}-1 javac{color}. The applied patch generated 20 javac compiler warnings (more than the master's current 13 warnings). {color:green}+1 protoc{color}. The applied patch does not increase the total number of protoc compiler warnings. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 5 warning messages. {color:red}-1 checkstyle{color}. The applied patch generated 1914 checkstyle errors (more than the master's current 1898 errors). {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: + * Fetches the short at the given index. Does not change position of the underlying ByteBuffers. The + * difference for this API from {@link #getShort(int)} is the caller is sure that the index will be + * Fetches the long at the given index. Does not change position of the underlying ByteBuffers. The + public static void copy(ByteBuffer src, int srcOffset, ByteBuffer dest, int destOffset, int length) { + assertBuffersEqual(new MultiByteBuffer(expectedBuffer), actualBuffer, algo, encoding, pread); {color:green}+1 site{color}. The mvn post-site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: {color:red}-1 core zombie tests{color}. There are 4 zombie test(s): at org.apache.hadoop.hbase.security.access.TestWithDisabledAuthorization.testPassiveMasterOperations(TestWithDisabledAuthorization.java:516) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14654//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14654//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14654//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14654//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14654//console This message is automatically generated. > HFileBlock backed by Array of ByteBuffers > ----------------------------------------- > > Key: HBASE-12213 > URL: https://issues.apache.org/jira/browse/HBASE-12213 > Project: HBase > Issue Type: Sub-task > Components: regionserver, Scanners > Reporter: Anoop Sam John > Assignee: ramkrishna.s.vasudevan > Attachments: HBASE-12213_1.patch, HBASE-12213_2.patch > > > In L2 cache (offheap) an HFile block might have been cached into multiple > chunks of buffers. If HFileBlock need single BB, we will end up in recreation > of bigger BB and copying. Instead we can make HFileBlock to serve data from > an array of BBs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)