[ 
https://issues.apache.org/jira/browse/HBASE-13965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14623151#comment-14623151
 ] 

Hadoop QA commented on HBASE-13965:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12744790/HBASE-13965-v7.patch
  against master branch at commit c16bbf47cbb1017b92960e15edfaa81cfd104b1d.
  ATTACHMENT ID: 12744790

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 8 new 
or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +      if 
(!server.getConfiguration().getBoolean(HConstants.HBASE_MASTER_LOADBALANCE_BYTABLE,
 false)) {
+      ((MetricsStochasticBalancer) 
metricsBalancer).updateStochasticCost(tableName.getNameAsString(), "Overall",
+        ((MetricsStochasticBalancer) 
metricsBalancer).updateStochasticCost(tableName.getNameAsString(),

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       
org.apache.hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14745//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14745//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14745//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/14745//console

This message is automatically generated.

> Stochastic Load Balancer JMX Metrics
> ------------------------------------
>
>                 Key: HBASE-13965
>                 URL: https://issues.apache.org/jira/browse/HBASE-13965
>             Project: HBase
>          Issue Type: Improvement
>          Components: Balancer, metrics
>            Reporter: Lei Chen
>            Assignee: Lei Chen
>         Attachments: HBASE-13965-v3.patch, HBASE-13965-v4.patch, 
> HBASE-13965-v5.patch, HBASE-13965-v6.patch, HBASE-13965-v7.patch, 
> HBASE-13965_v2.patch, HBase-13965-v1.patch, 
> stochasticloadbalancerclasses_v2.png
>
>
> Today’s default HBase load balancer (the Stochastic load balancer) is cost 
> function based. The cost function weights are tunable but no visibility into 
> those cost function results is directly provided.
> A driving example is a cluster we have been tuning which has skewed rack size 
> (one rack has half the nodes of the other few racks). We are tuning the 
> cluster for uniform response time from all region servers with the ability to 
> tolerate a rack failure. Balancing LocalityCost, RegionReplicaRack Cost and 
> RegionCountSkew Cost is difficult without a way to attribute each cost 
> function’s contribution to overall cost. 
> What this jira proposes is to provide visibility via JMX into each cost 
> function of the stochastic load balancer, as well as the overall cost of the 
> balancing plan.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to