[
https://issues.apache.org/jira/browse/HBASE-12296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14624522#comment-14624522
]
ramkrishna.s.vasudevan commented on HBASE-12296:
------------------------------------------------
Patch LGTM. Two things
The newly added compareXXX methods can be in CellComparator or in CellUtil?
ByteArrayComparable is
{code}
public abstract class ByteArrayComparable implements Comparable<byte[]>
{code}
Now we are using that to compare ByteBuffers also. I know it is a IA.public
interface. Can we rename it by deprecating the existing one in 2.0? Rest all
looks fine to me. The refactoring for the FamilyFilter, QualFilter, RowFilter
and ValFilter looks great.
> Filters should work with ByteBufferedCell
> -----------------------------------------
>
> Key: HBASE-12296
> URL: https://issues.apache.org/jira/browse/HBASE-12296
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver, Scanners
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 2.0.0
>
> Attachments: HBASE-12296_v1.patch
>
>
> Now we have added an extension for Cell in server side, ByteBufferedCell,
> where Cells are backed by BB (on heap or off heap). When the Cell is backed
> by off heap buffer, the getXXXArray() APIs has to create temp byte[] and do
> data copy and return that. This will be bit costly. We have avoided this in
> areas like CellComparator/SQM etc. Filter area was not touched in that patch.
> This Jira aims at doing it in Filter area.
> Eg : SCVF checking the cell value for the given value condition. It uses
> getValueArray() to get cell value bytes. When the cell is BB backed, it has
> to use getValueByteBuffer() API instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
